Back to the main page.

Bug 1482 - elec.tra created/updated during ave-reref?

Status CLOSED FIXED
Reported 2012-05-18 12:30:00 +0200
Modified 2019-08-10 12:40:26 +0200
Product: FieldTrip
Component: preproc
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P3 normal
Assigned to: Arjen Stolk
URL:
Tags:
Depends on:
Blocks:
See also:

Johanna - 2012-05-18 12:30:48 +0200

Related to bug 1481, I wonder if elec.tra should be created and/or updated in preproc.m when cfg.reref is used? In the 'normal' case of average-rereference, it doesn't matter that much, but for clarity/completeness might be nice to have and for other types of re-referencing.


Jan-Mathijs Schoffelen - 2012-09-19 15:37:47 +0200

I agree.


Johanna - 2013-09-24 16:54:32 +0200

Hi JM, I guess I'll reassign this to you too along with 1481.


Robert Oostenveld - 2017-05-08 09:07:09 +0200

this is also addressed in https://github.com/fieldtrip/fieldtrip/pull/415


Robert Oostenveld - 2017-05-08 10:40:03 +0200

[bug1482-reref 60e2b4d] apply the montage also in case data is read from disk, use ft_prepare_montage in case reref options are specified 1 file changed, 34 insertions(+), 21 deletions(-) mac011> git commit [bug1482-reref 1aca62d] implemented a helper function to create a montage from reref config options, see #415 and http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=1482 2 files changed, 186 insertions(+) create mode 100644 ft_prepare_montage.m create mode 100644 test/test_bug1482.m


Arjen Stolk - 2017-05-09 00:54:25 +0200

Grazie mille, Roberto! For code changes: https://github.com/fieldtrip/fieldtrip/pull/427


Robert Oostenveld - 2019-08-10 12:34:16 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.


Robert Oostenveld - 2019-08-10 12:40:26 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.