Back to the main page.
Bug 2519 - isequalwithequalnans is not recommended, use isequaln instead
| Status | CLOSED FIXED |
| Reported | 2014-04-02 21:13:00 +0200 |
| Modified | 2019-08-10 12:29:02 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P5 minor |
| Assigned to: | Eelke Spaak |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Robert Oostenveld - 2014-04-02 21:13:29 +0200
the summary is a warning that the matlab2014a editor gives. todo: check in which matlab version isequalwithequalnans became deprecated and if possible replace it according to the mathworks suggesion.
Eelke Spaak - 2014-06-24 09:40:25 +0200
Apparently isequaln is not yet present in R2011a (see 2622). It also is not present in R2011b, but it is present in R2012a. I will write a compatibility wrapper that calls isequalwithequalnans, and only add this to the path in case an old matlab is used. Thus we can migrate the code to using isequaln after I add the wrapper.
Eelke Spaak - 2014-06-24 09:50:33 +0200
bash-4.1$ svn commit compat/ ft_defaults.m Adding compat/matlablt2012a Adding compat/matlablt2012a/isequaln.m Sending ft_defaults.m Transmitting file data .. Committed revision 9674.
Eelke Spaak - 2014-08-06 13:15:16 +0200
Replaced them all: Sending ft_appenddata.m Sending ft_electroderealign.m Sending test/test_bug1129.m Sending test/test_bug1306.m Sending test/test_bug1443.m Sending test/test_bug1794.m Sending test/test_bug1988.m Sending test/test_ft_prepare_localspheres.m Sending test/test_ft_preprocessing.m Sending test/test_ft_timelockanalysis_new.m Transmitting file data .......... Committed revision 9768. How I looked for all occurrences of isequalwithequalnans: bash-4.1$ grep -lr "isequalwithequalnans" . ./.svn/text-base/ft_appenddata.m.svn-base ./.svn/text-base/ft_electroderealign.m.svn-base ./.svn/tmp/tempfile.20.tmp ./.svn/tmp/ft_appenddata.m.tmp ./.svn/tmp/tempfile.25.tmp ./.svn/tmp/ft_appenddata.m.2.tmp ./.svn/tmp/tempfile.28.tmp ./.svn/tmp/ft_appenddata.m.3.tmp ./compat/matlablt2012a/isequaln.m ./compat/matlablt2012a/.svn/text-base/isequaln.m.svn-base ./test/.svn/text-base/test_ft_prepare_localspheres.m.svn-base ./test/.svn/text-base/test_ft_preprocessing.m.svn-base ./test/.svn/text-base/test_bug1129.m.svn-base ./test/.svn/text-base/test_bug1988.m.svn-base ./test/.svn/text-base/test_ft_timelockanalysis_new.m.svn-base ./test/.svn/text-base/test_bug1794.m.svn-base ./test/.svn/text-base/test_bug1443.m.svn-base ./test/.svn/text-base/test_bug1306.m.svn-base ./test/test_ft_prepare_localspheres.m ./test/test_ft_preprocessing.m ./test/test_bug1129.m ./test/test_bug1988.m ./test/test_ft_timelockanalysis_new.m ./test/test_bug1794.m ./test/test_bug1443.m ./test/test_bug1306.m ./ft_appenddata.m ./ft_electroderealign.m