Back to the main page.

Bug 1034 - private/spikesort has a non-standard way of debugging

Status CLOSED FIXED
Reported 2011-10-12 12:12:00 +0200
Modified 2012-08-23 10:33:50 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: All
Operating System: All
Importance: P4 enhancement
Assigned to: Robert Oostenveld
URL:
Tags:
Depends on:
Blocks:
See also:

Robert Oostenveld - 2011-10-12 12:12:44 +0200

It starts with the following code % use global flag for debugging global fb if isempty(fb) fb = 0; end but presumably the debugging is not needed any more. Hence, it should be removed altogether. TODO: also check on the use of "global fb" in all other *.m files


Boris Reuderink - 2011-11-17 10:46:34 +0100

Changed the status of bugs without a specific owner to UNCONFIRMED. I'll try to replicate these bugs (potentially involving the submitter), and change confirmed bugs to NEW. Boris


Boris Reuderink - 2011-12-07 11:42:12 +0100

Files containing "global fb" $ find . -name "*.m" | xargs grep -l "global fb" ./external/simbio/bounding_mesh.m ./external/openmeeg/private/bounding_mesh.m ./inverse/private/bounding_mesh.m ./utilities/warp_optim.m ./fileio/private/bounding_mesh.m ./fileio/private/read_ctf_meg4.m ./fileio/private/read_ctf_hc.m ./private/bounding_mesh.m ./private/find_nearest.m ./private/spikesort.m ./private/read_ctf_hc.m ./compat/ft_freqanalysis_mtmconvol_old.m ./forward/private/bounding_mesh.m ./ft_electroderealign.m ./ft_sensorrealign.m Tip: to see the offending lines, do: $ find . -name "*.m" | xargs grep -C 5 "global fb" | less


Jan-Mathijs Schoffelen - 2012-01-27 08:39:19 +0100

assigned bug to get all bugs lined up before the grand bug binge


Robert Oostenveld - 2012-05-31 16:37:10 +0200

note to self: I changed the following in mbp/fieldtrip-clean M external/simbio/bounding_mesh.m M external/openmeeg/private/bounding_mesh.m M inverse/private/bounding_mesh.m M utilities/warp_optim.m M fileio/private/bounding_mesh.m M fileio/private/read_ctf_meg4.m M fileio/private/read_ctf_hc.m M ft_electroderealign.m M ft_sensorrealign.m M private/bounding_mesh.m M private/find_nearest.m M private/spikesort.m M private/read_ctf_hc.m M forward/private/bounding_mesh.m


Robert Oostenveld - 2012-06-01 09:12:38 +0200

(In reply to comment #4) mbp> svn commit `cat out` Sending external/openmeeg/private/bounding_mesh.m Sending external/simbio/bounding_mesh.m Sending fileio/private/bounding_mesh.m Sending fileio/private/read_ctf_hc.m Sending fileio/private/read_ctf_meg4.m Sending forward/private/bounding_mesh.m Sending ft_electroderealign.m Sending ft_sensorrealign.m Sending inverse/private/bounding_mesh.m Sending private/bounding_mesh.m Sending private/find_nearest.m Sending private/read_ctf_hc.m Sending private/spikesort.m Sending utilities/warp_optim.m Transmitting file data .............. Committed revision 5835.


Robert Oostenveld - 2012-08-23 10:33:50 +0200

closed multiple bugs that have been resolved for some time