Back to the main page.
Bug 1083 - remove nested functions and use normal functions instead
Status | CLOSED FIXED |
Reported | 2011-10-27 14:42:00 +0200 |
Modified | 2012-08-23 14:02:03 +0200 |
Product: | FieldTrip |
Component: | core |
Version: | unspecified |
Hardware: | PC |
Operating System: | Mac OS |
Importance: | P1 normal |
Assigned to: | Jörn M. Horschig |
URL: | |
Tags: | |
Depends on: | |
Blocks: | |
See also: |
Robert Oostenveld - 2011-10-27 14:42:16 +0200
ft_neighbourplot uses the nested function showLabelInTitle. It is not needed to use nested functions, so please change the code to use a normal function instead. After that, please include the relevant ft_preamble stuff (which at the moment does not work due to teh nested function)
Jörn M. Horschig - 2011-11-10 16:20:30 +0100
It should not take much time to change it - although of course I prefer the nested function due to it's simplicity, but I can understand why it should not be used (and I saw that you updated the code guidelines accordingly).
Jörn M. Horschig - 2011-11-10 16:23:01 +0100
*** Bug 1105 has been marked as a duplicate of this bug. ***
Jörn M. Horschig - 2011-11-23 12:14:59 +0100
Fixed. svn ci ft_neighbourplot.m -m "bugfix-#1083- added ft_preamble and postamble to neighbourplot and replaced the nested function" Sending ft_neighbourplot.m Transmitting file data . Committed revision 4799.
Jörn M. Horschig - 2011-11-23 12:16:21 +0100
.