Back to the main page.
Bug 122 - ft_rejectartifact doesn't work with data in input when calling artifact_xxx
| Status | CLOSED FIXED |
| Reported | 2010-07-24 14:08:00 +0200 |
| Modified | 2011-01-06 09:14:57 +0100 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P1 normal |
| Assigned to: | Jan-Mathijs Schoffelen |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Jan-Mathijs Schoffelen - 2010-07-24 14:08:39 +0200
This is reported by John Iversen: Hi FT Developers, Thanks for the continued improvements to Fieldtrip. I'm following the changes with interest and appreciation. I've made the following changes to ft_rejectartifact.m. The FT version (I believe I am up to date) does not handle the ft_rejectartifact(cfg, data) condition, in that it doesn't pass data along to any of the ft_artifact_* functions. Please let me know if this change is correct. (The cfg.trl line can go away as soon as the artifact functions are also updated to used data.sampleinfo...) Best, John ==== diff --git a/ft_rejectartifact.m b/ft_rejectartifact.m index c66d5fa..35d5645 100644 --- a/ft_rejectartifact.m +++ b/ft_rejectartifact.m @@ -214,7 +214,13 @@ cfg.artfctdef.type = cfg.artfctdef.type(:)'; for type=1:length(cfg.artfctdef.type) fprintf('evaluating artifact_%s\n', cfg.artfctdef.type{type}); % each call to artifact_xxx adds cfg.artfctdef.xxx.artifact - cfg = feval(sprintf('artifact_%s', cfg.artfctdef.type{type}), cfg); + %*** JRI *** fix bug, so can use data + if nargin==1, + cfg = feval(sprintf('ft_artifact_%s', cfg.artfctdef.type{type}), cfg); + else + cfg.trl = data.cfg.trl; + cfg = feval(sprintf('ft_artifact_%s', cfg.artfctdef.type{type}), cfg, data); + end end ==== Will fix a.s.a.p.