Back to the main page.

Bug 1236 - ft_getopt is not properly implemented in sourceanalysis

Reported 2011-12-19 14:09:00 +0100
Modified 2012-01-03 11:30:21 +0100
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P3 blocker
Assigned to: Jan-Mathijs Schoffelen
Depends on:
See also:

Jörn M. Horschig - 2011-12-19 14:09:35 +0100

e.g. setting cfg.keepfilters = 'yes' will be ignored This is because in line 265, a new subcfg is created for the respective method. These fields will be filled with a default which is *independent* of what the user specified in cfg. This clearly causes wrong behaviour of the function Proposed fix: Change the default input argument to cfg.keepfilter/keepcsd/keepmom/... instead of a default independent of the cfg Set severity to 'blocker' because this bug will cause scripts to crash, e.g. when relying on the filter that should be returned (it's at least 'critical', because important settings will not be regarded, e.g. the regularization parameter lambda)

Jan-Mathijs Schoffelen - 2011-12-21 14:01:00 +0100

call to ft_checkconfig to create subcfg should occur before the assigment of the default values. fixed in revision 5062