Back to the main page.
Bug 1245 - sens2lay (subfunction to ft_prepare_layout) does not always take a user specified subselection of channels into account
Status | CLOSED FIXED |
Reported | 2012-01-04 12:35:00 +0100 |
Modified | 2012-03-21 15:44:36 +0100 |
Product: | FieldTrip |
Component: | core |
Version: | unspecified |
Hardware: | PC |
Operating System: | Windows |
Importance: | P3 normal |
Assigned to: | Jan-Mathijs Schoffelen |
URL: | |
Tags: | |
Depends on: | |
Blocks: | |
See also: |
Vladimir Litvak - 2012-01-04 12:35:01 +0100
Hi, I was looking into a problem with plotting in SPM's interactive plotting tool which is a wrapper around FT code and it comes down to the fact that in ft_prepare _layout the cfg.channel field is not always used. In that particular case the layout is generated from cfg.elec field which has some extra sensors that should not be plotted, but the layout is generated at line 261 from all sensors without any further selection based on cfg.channel. Then in ft_multiplotER the selection of channels to plot is based on the layout and not on cfg.channel. So what happens eventually is that some auxiliary channels with very high values are included in the plot and the plot is wrongly scaled as a result so nothing works. Please fix. Thanks, Vladimir
Jan-Mathijs Schoffelen - 2012-01-10 10:26:09 +0100
this apparently leads to scaling issues in plotting functions that do an automatic scaling based on all data values. @Vladimi: could you upload some problematic data please, including a small script/cfg to reproduce the problem?
Vladimir Litvak - 2012-01-10 12:03:16 +0100
Created attachment 212 Bug test data Load and do: ft_multiplotER(cfg, data);
Jan-Mathijs Schoffelen - 2012-01-10 12:36:57 +0100
thanks. JM
Jan-Mathijs Schoffelen - 2012-01-10 13:16:38 +0100
reproduced and fixed in revision 5105. The issue was related to the fact that the algorithm that determines the scale does not take only the to-be-plotted channels.
Vladimir Litvak - 2012-01-10 15:27:53 +0100
Hi JM, This fix is not sufficient because: 1) Although the extra channels are not taken into account for scaling they are still plotted which is not what the user wants. 2) The scaling of the topoplot that one gets from the interactive feature is still wrong and does use the bad channels. VL
Jan-Mathijs Schoffelen - 2012-01-10 15:33:09 +0100
OK. Sorry. I'll look into this soon.