Back to the main page.

Bug 1374 - check for consistent use of preamble loadvar and subsequent cfg.inputfile and cfg.outputfile

Reported 2012-03-14 15:29:00 +0100
Modified 2014-03-12 12:21:38 +0100
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P3 trivial
Assigned to: Jörn M. Horschig
Depends on:
See also:

Jörn M. Horschig - 2012-03-14 15:29:10 +0100

In a short meeting with Robert, we encountered several small things to be changed (all with low priority). For example some functions still check for cfg.inputfile or cfg.outputfile although their usage is covered in the preamble function. The subsequent checks should be removed

Jörn M. Horschig - 2013-01-23 16:51:17 +0100

Sending ft_appendfreq.m Sending ft_componentanalysis.m Sending ft_freqanalysis.m Sending ft_freqbaseline.m Sending ft_freqdescriptives.m Sending ft_freqgrandaverage.m Sending ft_multiplotTFR.m Sending ft_networkanalysis.m Sending ft_prepare_neighbours.m Sending ft_regressconfound.m Sending ft_rejectcomponent.m Sending ft_sourceinterpolate.m Sending ft_sourceplot.m Sending ft_timelockgrandaverage.m Sending ft_volumenormalise.m Sending ft_volumerealign.m Sending ft_volumereslice.m Sending ft_volumewrite.m Transmitting file data .................. Committed revision 7398.

Robert Oostenveld - 2013-01-23 17:56:23 +0100

we had some problems with inputfile, which showed up in the dashboard towards the end of the bug binge. See bug 1951. Using grep, I still see the following suspicious use of inputfile. I am not sure whether these are problematic, but they should be carefully checked. ft_connectivityanalysis.m:cfg.inputfile = ft_getopt(cfg, 'inputfile', []); ft_layoutplot.m: if isfield(cfg, 'inputfile') ft_layoutplot.m: dataname = cfg.inputfile; ft_megplanar.m:cfg.inputfile = ft_getopt(cfg, 'inputfile', []); ft_movieplotTFR.m:cfg.inputfile = ft_getopt(cfg, 'inputfile', []); ft_multiplotER.m: iname{i+1} = cfg.inputfile{i}; ft_multiplotER.m: dataname = cfg.inputfile; ft_multiplotER.m:if isfield(cfg, 'inputfile') ft_multiplotER.m: cfg = rmfield(cfg, 'inputfile'); ft_multiplotER.m: if isfield(cfg, 'inputfile') ft_multiplotER.m: cfg = rmfield(cfg, 'inputfile'); ft_multiplotTFR.m: dataname = cfg.inputfile; ft_multiplotTFR.m:if isfield(cfg, 'inputfile') ft_multiplotTFR.m: cfg = rmfield(cfg, 'inputfile'); ft_multiplotTFR.m: if isfield(cfg, 'inputfile') ft_multiplotTFR.m: cfg = rmfield(cfg, 'inputfile'); ft_singleplotER.m: iname{i+1} = cfg.inputfile{i}; ft_singleplotER.m: dataname = cfg.inputfile; ft_singleplotER.m:if isfield(cfg, 'inputfile') ft_singleplotER.m: cfg = rmfield(cfg, 'inputfile'); ft_singleplotTFR.m: dataname = cfg.inputfile; ft_singleplotTFR.m:if isfield(cfg, 'inputfile') ft_singleplotTFR.m: cfg = rmfield(cfg, 'inputfile'); ft_volumesegment.m:cfg.inputfile = ft_getopt(cfg, 'inputfile', []); also using grep, I see the following suspicious use of outputfile ft_componentanalysis.m: tmpcfg.outputfile = cfg.outputfile; ft_connectivityanalysis.m:cfg.outputfile = ft_getopt(cfg, 'outputfile', []); ft_freqstatistics.m:cfg.outputfile = ft_getopt(cfg, 'outputfile', []); ft_megplanar.m:cfg.outputfile = ft_getopt(cfg, 'outputfile', []); ft_volumesegment.m:cfg.outputfile = ft_getopt(cfg, 'outputfile', []);

Diego Lozano Soldevilla - 2013-01-25 15:29:34 +0100

(In reply to comment #2) I delete line 221 tmpcfg.outputfile = cfg.outputfile in ft_componentanalysis because it make a reference to non-existent field 'outputfile'. Committed revision 7410

Jörn M. Horschig - 2013-01-31 11:33:18 +0100

svn ci ft_connectivityanalysis.m ft_volumesegment.m ft_freqstatistics.m ft_megplanar.m -m "enhancement - #1374 - unnecessary assignments of cfg.out-/inputfile removed" Sending ft_connectivityanalysis.m Sending ft_freqstatistics.m Sending ft_megplanar.m Sending ft_volumesegment.m Transmitting file data .... Committed revision 7428. the plot functions use the inputfilename for determing the name of the window, so that shouldn't be touched.