Back to the main page.
Bug 1424 - ft_databrowser: cfg.compscale default confusing
Status | CLOSED FIXED |
Reported | 2012-04-13 12:51:00 +0200 |
Modified | 2012-08-22 17:33:18 +0200 |
Product: | FieldTrip |
Component: | core |
Version: | unspecified |
Hardware: | PC |
Operating System: | Windows |
Importance: | P3 normal |
Assigned to: | Johanna |
URL: | |
Tags: | |
Depends on: | |
Blocks: | |
See also: |
Johanna - 2012-04-13 12:51:39 +0200
The help-comments for cfg.compscale say that 'local' is the default, but line 154 of the code shows that 'global' is the default. A very easy fix, but before doing so, just checking what *should* be default behavior? I vote for 'local'.
Jörn M. Horschig - 2012-04-13 13:12:22 +0200
whoopa, my bad! It is related to bug 1335, there I wrote this: "default is 'global' scaling using 'maxmin' The previous default was some kind of mix between maxmin and maxabs: Every topography was scaled by it's own absolute maximum, but by MATLAB default the color scheme was adjusted according to the global minimum and maximum" btw, Johanna, you and Eelke voted for 'global' in bug 1335 - my intention back then was to make 'local' the default ;)
Johanna - 2012-04-13 13:23:15 +0200
I was just looking at a component structure in which the first 2 components had much greater power than the rest, thus the only way to see the spatial structure of the remaining components was to use 'local', hence my vote here for 'local'.
Robert Oostenveld - 2012-04-13 13:24:52 +0200
I refrain from voting
Jörn M. Horschig - 2012-04-13 14:56:03 +0200
(In reply to comment #2) Same for me, that's why I implemented the option :) (In reply to comment #3) anarchy!
Roemer van der Meij - 2012-05-16 13:46:03 +0200
keep the default global and update the documentation. this was voted by majority in an FT-meeting with 4 people present