Back to the main page.
Bug 1435 - trialfun_XXX should be ft_prefixed(?)
| Status | CLOSED FIXED |
| Reported | 2012-04-18 15:30:00 +0200 |
| Modified | 2012-08-23 10:35:13 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P3 normal |
| Assigned to: | Eelke Spaak |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | 640 |
| See also: |
Roemer van der Meij - 2012-04-18 15:30:41 +0200
To be discussed in meeting.
Roemer van der Meij - 2012-04-18 15:31:23 +0200
Important: people use their own (un-prefixed) trialfuns
Robert Oostenveld - 2012-04-18 20:31:36 +0200
see also bug #1434
Robert Oostenveld - 2012-05-01 23:17:30 +0200
see also bug #640
Eelke Spaak - 2012-08-06 14:37:02 +0200
Committed in revision 6326. Will now quickly browse through tutorial(s) and update where necessary.
Eelke Spaak - 2012-08-06 14:41:29 +0200
Added cfg.trialfun='ft_trialfun_general' to the very first call of ft_definetrial in the preprocessing tutorial. Mentioned that this is the default, probably informative for newbies. Note: I added two helper functions to /trialfun/private/, might be of future use to others as well: -- function b = isfunction(funcname) %ISFUNCTION tests whether the function of the specified name is a callable % function on the current Matlab path. % % Note that this is *not* equivalent to calling exist(funcname, 'file'), % since that will return 7 in case funcname exists as a folder. -- function b = iscompatwrapper(funcname) %ISCOMPATWRAPPER Checks whether the specified function name will invoke a % compatibility wrapper or not.
Eelke Spaak - 2012-08-06 15:06:37 +0200
Note 2: I again changed the handling a bit, by introducing a utilities/ft_getuserfun.m file that is now responsible for all handling of user functions. This will ensure consistency across the code (once I'm done with browsefun and statfun as well). The helper functions mentioned in my previous comment have been moved to utilities/private/ in accordance.
Roemer van der Meij - 2012-08-07 14:50:51 +0200
Just as a note, I added an iscompatwrapper check to the first isfunc check. When I called ft_getuserfun('multiplotER', 'browse'), it extracted the compat one ;)