Back to the main page.

Bug 1459 - ft_multiplotTFR needs some fixes

Status CLOSED FIXED
Reported 2012-05-07 22:01:00 +0200
Modified 2013-01-17 10:43:31 +0100
Product: FieldTrip
Component: plotting
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P3 normal
Assigned to: Roemer van der Meij
URL:
Tags:
Depends on:
Blocks:
See also:

Robert Oostenveld - 2012-05-07 22:01:31 +0200

line 249, ft_plot_lay should not be done at that place. it replicates the code around line 505 TODO check all multiplot and topoplot functions on correct ft_plot_lay for outline ft_multiplotTFR uses local positioning of sub-axes, whereas that should be done with ft_plot_matrix TODO check all multiplot and topoplot functions on correct usage of ft_plot_vector and ft_plot_matrix. suspicious are the following mbp> grep ft_plot_vector *.m | grep -v hpos ft_multiplotER.m: ft_plot_vector(xs,ys,'color','b'); ft_multiplotER.m: ft_plot_vector(xs,ys,'color','b'); mbp> grep ft_plot_matrix *.m | grep -v hpos ft_multiplotTFR.m: ft_plot_matrix(xas, yas, cdata,'clim',[zmin zmax],'tag','cip','highlightstyle',cfg.maskstyle,'highlight', mask) ft_multiplotTFR.m: ft_plot_matrix(xas, yas, cdata,'clim',[zmin zmax],'tag','cip','highlightstyle',cfg.maskstyle,'highlight', mask) ft_multiplotTFR.m: ft_plot_matrix(xas, yas, cdata,'clim',[zmin zmax],'tag','cip','highlightstyle',cfg.maskstyle,'highlight', mask) ft_multiplotTFR.m: ft_plot_matrix(xas, yas, cdata,'clim',[zmin zmax],'tag','cip') ft_multiplotTFR.m: ft_plot_matrix(xas, yas, cdata,'clim',[zmin zmax],'tag','cip','highlightstyle',cfg.maskstyle,'highlight', mask) ft_multiplotTFR.m: ft_plot_matrix(xas, yas, cdata,'clim',[zmin zmax],'tag','cip','highlightstyle',cfg.maskstyle,'highlight', mask) ft_multiplotTFR.m: ft_plot_matrix(xas, yas, cdata,'clim',[zmin zmax],'tag','cip','highlightstyle',cfg.maskstyle,'highlight', mask) ft_multiplotTFR.m: ft_plot_matrix(xas, yas, cdata,'clim',[zmin zmax],'tag','cip')


Roemer van der Meij - 2012-05-29 12:41:08 +0200

See bugs for other fixes to multiplotTFR bug 1456 bug 1476 bug 1492


Roemer van der Meij - 2012-07-12 16:23:05 +0200

All fixed. ft_multiplotTFR no longer uses local position of subaxis (but relies on ft_plot_matrix), and ft_plot_lay is properly used. Duplicate code is removed.


Roemer van der Meij - 2013-01-17 10:43:31 +0100

bug closing time