Back to the main page.
Bug 1547 - rename cfg.vol into cfg.headmodel and cfg.grid into cfg.sourcemodel
| Status | CLOSED FIXED |
| Reported | 2012-06-22 10:06:00 +0200 |
| Modified | 2019-08-10 12:43:47 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P5 trivial |
| Assigned to: | |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: | http://bugzilla.fcdonders.nl/show_bug.cgi?id=1078http://bugzilla.fcdonders.nl/show_bug.cgi?id=1285 |
Robert Oostenveld - 2012-06-22 10:06:09 +0200
this makes it consistent with the nomenclature used elsewhere and allows the users to specify cfg.headmodel = ft_prepare_headmodel(...) cfg.sourcemodel = ft_prepare_sourcemodel(...) This requires some thought, and we might also want to rethink the other structures like this (lay vs layout) and especially rethink the way that we either use MATLAB variables or use (mat) files containing the variable. Other examples might be cfg.layout = ft_read_layout(filename) cfg.mri = ft_read_mri(filename) cfg.elec = ft_read_sens(filename) cfg.grad = ft_read_sens(filename) -> should we have ft_read_elec and ft_read_grad as wrappers around ft_read_sens? -> should we generally allow for cfg.something = struct() and cfg.something = 'string', where in the latter case ft_read_something would be called on the string? TO BE DISCUSSED IN ONE OF THE MEETINGS (but not urgent)
Robert Oostenveld - 2012-07-02 22:54:46 +0200
See also bug 1258 and bug 1078 which pertain to ft_fetch_vol and ft_fetch_sens.
Robert Oostenveld - 2012-07-02 22:55:57 +0200
(In reply to comment #1) Sorry, that should read > See also bug 1285 and bug 1078 which pertain to ft_fetch_vol and ft_fetch_sens. i.e. 1285 instead of 1258.
Jörn M. Horschig - 2014-01-29 16:05:05 +0100
a friendly reminder that you said that this should be discussed in one of the meeting. I like the idea.
Robert Oostenveld - 2015-07-15 18:46:51 +0200
It is more work than I suspected. I have been working on the code for a few hours and replaced cfg.vol/vol into cfg.headmodel/headmodel. There are also functions with vol in the name, these include ./fileio/private/ama2vol.m ./fileio/private/ft_datatype_vol.m ./fileio/private/ft_voltype.m ./fileio/private/read_asa_vol.m ./fileio/private/yokogawa2vol.m ./fileio/ft_read_vol.m ./forward/private/ama2vol.m ./forward/ft_inside_vol.m ./forward/ft_prepare_vol_sens.m ./forward/ft_transform_vol.m ./forward/ft_voltype.m ./inverse/private/find_inside_vol.m ./inverse/private/ft_inside_vol.m ./inverse/private/ft_voltype.m ./plotting/private/ft_voltype.m ./plotting/test/test_ft_plot_vol.m ./plotting/ft_plot_vol.m ./private/ft_fetch_vol.m ./private/volplot.m ./test/test_ft_prepare_vol_sens.m Furthermore, there is documentation on the WIKI where vol is used but where headmodel should be used. The most important is http://www.fieldtriptoolbox.org/development/forward
Robert Oostenveld - 2015-07-15 18:49:55 +0200
(In reply to Robert Oostenveld from comment #4) Transmitting file data ..................................................... Committed revision 10541.
Jan-Mathijs Schoffelen - 2015-07-15 21:33:04 +0200
owja, volplot. leuke functie... heeft verder niet veel met headmodels te maken.
Jan-Mathijs Schoffelen - 2019-03-04 14:26:38 +0100
I think that Robert has taken care of this now, in the course of working on the reproducescript functionality...