Back to the main page.

Bug 1566 - .offset output in eeglab2fieldtrip obsolete

Reported 2012-06-28 10:29:00 +0200
Modified 2012-07-14 14:43:39 +0200
Product: FieldTrip
Component: external
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P3 normal
Assigned to: Robert Oostenveld
Depends on:
See also:

Johanna - 2012-06-28 10:29:27 +0200

not causing problems, but unncessary.

Johanna - 2012-07-02 11:39:55 +0200

Hi Robert, I tried making this trivial change to delete the 2 lines where .offset is created, but the SVN won't let me. JM informs me that special permissions are needed for modifying code in external/*. May I have permission for this? Otherwise, someone with permissions can do it for me, by deleting lines 100 and 117 in eeglab2fieldtrip.m

Robert Oostenveld - 2012-07-02 11:55:20 +0200

The change has to be made in the eeglab SVN repository. Then the files in eeglab have to be synched again, i.e. our copy of the external files has to be updated. Only Arno and me have write access in the external/eeglab directory. I suggest you ask Arno to make the change in eeglab, and then I'll update our copy of the eeglab files.

Johanna - 2012-07-02 12:03:47 +0200

Dear Arno, Could you please make this small change to eeglab2fieldtrip.m to remove the two lines where .offset are created? (they are no longer needed in FT). Then Robert will sync this version to the FieldTrip code. Thank you, Johanna

Robert Oostenveld - 2012-07-05 11:07:34 +0200

Hi Arno, This one is for you, please assign it back to me when you are done. Robert

Arnaud Delorme - 2012-07-05 21:05:47 +0200

OK, I have updated the EEGLAB SVN with a version of eeglab2fieldtrip.m without the ".offset" field. I trust you guys that this will not have any deleterious effects.

Arnaud Delorme - 2012-07-14 01:00:17 +0200

Can we close this bug now. It has been reopened? Arno