Back to the main page.

Bug 1583 - ft_prepare_sourcemodel should use ft_fetch_sens and ft_fetch_vol

Reported 2012-07-02 23:10:00 +0200
Modified 2012-08-23 14:02:11 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P3 normal
Assigned to: Jörn M. Horschig
Depends on:
See also:

Robert Oostenveld - 2012-07-02 23:10:10 +0200

At this moment it does % cfg.vol = volume conduction model % cfg.grad = gradiometer definition % cfg.elec = electrode definition but not cfg.hdmfile cfg.gradfile cfg.elecfile which you would expect, given that all other functions allow these fields as alternatives.

Robert Oostenveld - 2012-07-02 23:13:11 +0200

The following automatic searches suggest that some other functions also need to be checked on their consistent use of xxx and xxxfile. mbp> grep -L cfg.elecfile `grep -l cfg.elec *.m` ft_databrowser.m ft_prepare_headmodel.m ft_prepare_sourcemodel.m mbp> grep -L cfg.gradfile `grep -l cfg.grad *.m` ft_databrowser.m ft_denoise_synthetic.m ft_multiplotTFR.m ft_prepare_headmodel.m ft_prepare_sourcemodel.m ft_rejectvisual.m mbp> grep -L cfg.hdmfile `grep -l cfg.vol *.m` ft_prepare_sourcemodel.m PS please note that besides the direct use of ft_fetch_vol/ft_fetch_sens another possibility is that private/prepare_heademodel is being used to "fetch" them.

Jörn M. Horschig - 2012-07-25 11:35:15 +0200

only update databrowser and ft_prepare_sourcemodel, and update some documentation the other functions you mentioned were either already using the new way or had cfg fields like cfg.gradient or cfg.gradscale, thus not applicable for fetch_sens or _vol svn ci private/ft_fetch_vol.m ft_prepare_sourcemodel.m ft_databrowser.m -m "enhancement-#1583- sensor position and headmodel fetching updated" Sending ft_databrowser.m Sending ft_prepare_sourcemodel.m Sending private/ft_fetch_vol.m Transmitting file data ... Committed revision 6283.

Jörn M. Horschig - 2012-08-23 14:02:11 +0200

bug closing time (