Back to the main page.

Bug 1611 - in ft_electroderealign, template not checked correctly?

Status	CLOSED FIXED
Reported	2012-07-13 17:12:00 +0200
Modified	2013-01-16 15:19:42 +0100
Product:	FieldTrip
Component:	core
Version:	unspecified
Hardware:	PC
Operating System:	Windows
Importance:	P3 normal
Assigned to:	Johanna
URL:
Tags:
Depends on:
Blocks:
See also:

---

Johanna - 2012-07-13 17:12:22 +0200

This goes on in the code starting line 171: clear tmp for i=1:Ntemplate tmp(i) = ft_convert_units(template(i), elec.unit); % ensure that the units are consistent with the electrodes tmp(i) = ft_datatype_sens(template(i)); % ensure up-to-date sensor descriptions (Oct 2011) end template = tmp; But the line calling ft_datatype_sens takes template(i) as input. That removes the effect of calling ft_convert_units on the previous, right? So instead, shouldn't ft_datatype_sens take tmp(i) as input?

---

Johanna - 2012-09-19 17:07:17 +0200

JM initially added the line (as fixsens, later upgraded to ft_datatype_sens) in r4287 http://code.google.com/p/fieldtrip/source/diff?path=/trunk/ft_electroderealign.m&format=side&r=4287&old_path=/trunk/ft_electroderealign.m&old=4096 Fixed now, svn commit 6479 JM: please comment/reopen if you think that it should remain the way you had it.