Back to the main page.

Bug 1613 - Unnecessary Yokogawa warning

Reported 2012-07-17 17:18:00 +0200
Modified 2012-11-29 09:13:09 +0100
Product: FieldTrip
Component: forward
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P3 minor
Assigned to: Jan-Mathijs Schoffelen
Depends on:
See also:

Vladimir Litvak - 2012-07-17 17:18:14 +0200

Hi, I'm trying to make the changes necessary for upgrading FT in SPM8 to the latest version. When doing ft_prepare_vol_sens on an old style elec struct with .pnt I get the warning: Warning: could be Yokogawa system > In forward\private\warning_once at 75 In ft_senstype at 291 In forward\private\channelposition at 46 In forward\private\ft_datatype_sens at 107 In ft_prepare_vol_sens at 67 This comes down to the way functions are called and particularly that channelposition adds a fake ori field to all sensor structs at line 43 which makes ft_senstype think that it's a grad. This looks benign but SPM users don't like warnings and I had enough headache with that warning that came with the single shell model. Also this doesn't make any principled sense why the code should ever get to that point. Could this warning be suppressed? I don't want to do it myself because I think there should be a principled fix and I'm not sure which one you'd prefer. Best, Vladimir

Jan-Mathijs Schoffelen - 2012-07-18 13:42:51 +0200

Discussed in FT-meeting (Robert not present): the general consensus seems to be that the warning can be removed without too big consequences.

Vladimir Litvak - 2012-07-18 15:08:11 +0200

If you just remove this warning it'll solve my problem. The question is whether it's a good thing that starting with something that is clearly an EEG sensor description the code gets to a place which is supposed to only handle MEG sensors. This is a kind of thing that at least Robert wouldn't like to have as I know him, but I leave the fix at your discretion. Vladimir

Tilmann Sander-Thommes - 2012-08-07 11:12:16 +0200

The "Warning: could be Yokogawa system" has rather the meaning: FieldTrip does not know the system. It was only related to Yokogawa as their systems are all different and therefore are not easily detectable. Therefore the warning could be replaced by something generic: Unknown system. Vladimir´s comment needs some attention, it should not happen at all. But if an SPM user tries to load an unknown system she/he should be informed !? Till

Vladimir Litvak - 2012-09-27 13:08:54 +0200

(In reply to comment #3) OK I removed the warnings. I think the warning is not necessary the way the code works now since it will issue the warning every time when checking the lowercase version of the labels. So unless the code is changed in a way that the warning will only appear when something really unexpected happens, it shouldn't appear at all.