Back to the main page.
Bug 168 - ft_ prefixes are missing in the code (all realtime functions)
| Status | CLOSED FIXED |
| Reported | 2010-09-22 17:57:00 +0200 |
| Modified | 2012-08-23 10:33:46 +0200 |
| Product: | FieldTrip |
| Component: | realtime |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P1 normal |
| Assigned to: | Robert Oostenveld |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Saskia Haegens - 2010-09-22 17:57:58 +0200
i just updated the help documentation for these functions, but then noticed that in the code (when calling other fieldtrip functions) no ft_ prefixes are used
Stefan Klanke - 2010-11-25 13:58:05 +0100
I added ft_ prefixes to (hopefully) all Fieldtrip function calls in realtime and realtime/datasource. ft_realtime_topography and ft_realtime_downsample contain a call to "preproc" which I don't know anything about.
Stefan Klanke - 2010-12-08 17:07:02 +0100
Replaced call to preproc in ft_realtime_downsampling with online_filter + online_downsampling helper functions from utility (handling continouos stream), and added cfg options to specify downsampling rate etc. Don't know how to deal with ft_realtime_topography's preproc (or even what that does). All the others functions should now be properly prefixed.
Robert Oostenveld - 2010-12-15 21:24:36 +0100
fixed in rev 2441
Robert Oostenveld - 2011-01-05 11:57:02 +0100
selected a long list of resolved bugs from roboos and changed the status into "RESOLVED"
Robert Oostenveld - 2011-01-05 12:01:07 +0100
selected all old bugs from roboos with status RESOLVED and changed it into CLOSED
Boris Reuderink - 2012-04-27 10:47:02 +0200
Hi Robert, I notice that test_bug168 does not finish. The documentation states that ft_realtime_topography has to be ended with Ctrl-C. Is it expected that this test script finishes? If not, I would suggest to exclude this file form automated testing. Boris
Robert Oostenveld - 2012-04-27 13:13:41 +0200
(In reply to comment #6) It should somehow be excluded from automated testing. I suggest to add a "return" statement and a comment to the beginning of the code. Testing then requires someone to copy and paste the part after the return.
Boris Reuderink - 2012-04-27 13:47:40 +0200
I fixed it by renaming the file to inspect_bug168; the file name now indicates that human action is required, and it simultaneously exclude the file from being tested automatically (trigger is now a filename matching "*test/test*.m"). Would you favor your suggestion instead?
Robert Oostenveld - 2012-05-01 23:07:21 +0200
re-reading the initial bug, it appears to me that the particular test is not a very good detection for the compat functions. I changes the test_bug168 script into a more sensitive test for the actual problematic functions. With the updated test script, the following problem was found problem = '/Users/robert/matlab/fieldtrip/compat/channelselection.m' Error using test_bug168 (line 85) there are some files that depend on the compat functions Looking at it in more detail revealed that ft_realtime_downsample was calling channelselection instead of ft_channelselection. Besides the test script, I also fixed this. mbp> svn commit example/ft_realtime_downsample.m ../test/test_bug168.m Sending realtime/example/ft_realtime_downsample.m Sending test/test_bug168.m Transmitting file data .. Committed revision 5723.