Back to the main page.

Bug 1716 - ft_artifact_zvalue x-axis can show time rather than samples

Reported 2012-09-18 15:13:00 +0200
Modified 2014-03-12 12:21:42 +0100
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P3 enhancement
Assigned to: Jörn M. Horschig
Depends on:
See also:

Jörn M. Horschig - 2012-09-18 15:13:32 +0200

much more intuitive when looking at single trials to consider time in seconds relative to trigger onset rather than absolute sample number

Jörn M. Horschig - 2012-09-20 13:12:59 +0200

done. svn ci ft_artifact_zvalue.m -m "enhancement-#1716-ft_artifact_zvalue shows time rather than sample number" Sending ft_artifact_zvalue.m Transmitting file data . Committed revision 6497.

Jan-Mathijs Schoffelen - 2012-09-25 14:17:46 +0200

Does not work ok. The right subplots that show the single trial time courses now have the time axis of the whole recording! makes the function useless ;-)

Jan-Mathijs Schoffelen - 2012-09-26 10:08:21 +0200

Also, explicitly assuming that trl(:,3) exists (at the line where you added a 'bullshit' commentary) is dangerous; when the trl is reconstructed from the sampleinfo this does not work. Back to the drawing board it is.

Jörn M. Horschig - 2012-09-26 10:17:57 +0200

my apologies ;) gonna fix it now

Jörn M. Horschig - 2012-09-26 11:01:34 +0200

hm, cannot reproduce your problem with the time-axis, works fine for me. I fixed some things which might have caused this, but I am not really sure... could you check and if it still does not work share a bit of data? I fixed the problem trl(:, 3) such that if not already existent, I estimate the offset by the time-axis: t0 = interp1(data.time{tr}, 1:numel(data.time{tr}), 0, 'linear', 'extrap'); and I removed the 'bullshit' comment, meant to do no harm there ;) and I fixed a bug that made jumping to a specific trial impossible, cause it always jumped to trial 1 svn ci ft_artifact_zvalue.m -m "bugfix-#1716-ft_artifact_zvalue shows time axis properly and fixed some other minor things" Sending ft_artifact_zvalue.m Transmitting file data . Committed revision 6544.

Jörn M. Horschig - 2012-10-01 16:27:59 +0200

aloha heja JM, works better now?

Jörn M. Horschig - 2012-10-24 10:06:13 +0200

no complaint, no bug ;)