Back to the main page.
Bug 1863 - the svn test directory is filling up with mat files
Status | CLOSED FIXED |
Reported | 2012-11-29 10:07:00 +0100 |
Modified | 2015-07-15 13:22:26 +0200 |
Product: | FieldTrip |
Component: | test |
Version: | unspecified |
Hardware: | PC |
Operating System: | Mac OS |
Importance: | P3 normal |
Assigned to: | Jim Herring |
URL: | |
Tags: | |
Depends on: | |
Blocks: | |
See also: |
Robert Oostenveld - 2012-11-29 10:07:50 +0100
The consequence is that the fieldtrip release zip file is getting very "heavy". See below roboos@mentat001> du -hs *.mat 584K avgFIC.mat 4.2M bug1447.mat 35M bug1811.mat 192K spheres.mat 10M test_bug1027.mat 468K test_bug1035.mat 4.0K test_bug103.mat 4.0K test_bug1053.mat 80K test_bug1112.mat 2.8M test_bug1129.mat 7.4M test_bug1210.mat 944K test_bug1243.mat 952K test_bug1245.mat 6.2M test_bug1315.mat 1.4M test_bug1351.mat 600K test_bug1474.mat 132K test_bug1637_grad.mat 1.2M test_bug1637_hdr.mat 68K test_bug1651.mat 84K test_bug1735.mat 1.6M test_bug1754.mat 2.5M test_bug1759.mat 956K test_bug1760.mat 4.6M test_bug1800.mat 128K test_bug542.mat 736K test_bug564.mat 512K test_SPM_ft_integration.mat roboos@mentat001> du -hs . 192M . I suggest that we, where possible, use /home/common/matlab/fieldtrip/data/test for storing the test data. To make it easy to run tests both on windows and linux, we should have an easy and consistent way of switching between /home/common/matlab/fieldtrip/data/test and h:\common\matlab\fieldtrip\data\test Furthermore, I suggest that we try to use a consistent naming scheme for the mat files. On home/common we are mostly using bugXXX.mat, whereas on svn we seem to be mostly using test_bugXXX.mat. Which naming scheme to pick? TODO - decide on naming scheme - update scripts for * file name * file location (windows/linux friendly) - copy files to home/common - remove files from svn There might be some that we want to keep in fieldtrip/test on the svn, especially those that affect external collaborators (such as the SPM integration test).
Roemer van der Meij - 2012-11-29 10:50:32 +0100
I think it would be a good idea to name all test data identical to the script it is used in, either with or without a data prefix/suffix. For data that is used by multiple scripts it will be a bit more difficult though. But for most this would work.
Jim Herring - 2013-01-23 17:06:21 +0100
I will move the test_bugXXX.mat files to home/common and update the test scripts to use dccnfilename to correctly switch between windows/linux. I will not move the SPM integration mat-file.
Robert Oostenveld - 2013-01-23 17:11:25 +0100
the following test scripts are affected raspberry> grep "load test_bug" *.m inspect_bug1093.m:load test_bug1027; % use the data for bug1027 test_bug1027.m:load test_bug1027 test_bug1035.m:load test_bug1035.mat test_bug1053.m:load test_bug1053.mat test_bug1112.m:load test_bug1112 test_bug1125.m:load test_bug1129 test_bug1129.m:load test_bug1129 test_bug1210.m:load test_bug1210 test_bug1243.m:load test_bug1243; test_bug1245.m:load test_bug1245 test_bug1315.m:load test_bug1315.mat test_bug1351.m:load test_bug1351 test_bug1474.m:load test_bug1474.mat; test_bug1637.m:load test_bug1637_hdr; test_bug1637.m:load test_bug1637_grad; test_bug1735.m:load test_bug1735.mat test_bug1754.m:load test_bug1754 test_bug1759.m:load test_bug1759; test_bug1760.m:load test_bug1760 test_bug1800.m:load test_bug1800 tmpavg1; % Load the timelocked data test_bug1911.m:load test_bug1911.mat test_bug542.m:load test_bug542.mat
Robert Oostenveld - 2013-01-23 17:13:34 +0100
(In reply to comment #3) use the following to edit all of them in MATLAB raspberry> for file in `grep -l "load.*test_bug" *.m` ; do echo edit $file; done edit inspect_bug1093.m edit test_bug1027.m edit test_bug1035.m edit test_bug1053.m edit test_bug1112.m edit test_bug1125.m edit test_bug1129.m edit test_bug1210.m edit test_bug1243.m edit test_bug1245.m edit test_bug1315.m edit test_bug1351.m edit test_bug1474.m edit test_bug1637.m edit test_bug1735.m edit test_bug1754.m edit test_bug1759.m edit test_bug1760.m edit test_bug1800.m edit test_bug1911.m edit test_bug542.m
Jim Herring - 2013-02-27 13:28:16 +0100
The fieldtrip zip-file (both lite and regular) do not contain the test folder. Is this bug still relevant?