Back to the main page.
Bug 1889 - trialfun_general does not work on neurosim data, caused by ft_read_header
Status | CLOSED FIXED |
Reported | 2012-12-13 10:40:00 +0100 |
Modified | 2019-08-10 12:03:01 +0200 |
Product: | FieldTrip |
Component: | fileio |
Version: | unspecified |
Hardware: | PC |
Operating System: | Windows |
Importance: | P3 normal |
Assigned to: | Bart Gips |
URL: | |
Tags: | |
Depends on: | |
Blocks: | |
See also: |
Bart Gips - 2012-12-13 10:40:45 +0100
The test function test_tutorial_spike_Neurosim.m does not work. (in ./contrib/spike/test/) It relies on ft_trialfun_general. However, trialfun general calls ft_read_header to get sampling rate information. Since we removed filetype 'neurosim_spikes' from ft_read_header yesterday, it no longer works. This may also be true for other spike formats (that do not store spikes in a continuous manner). Possible options: -Put neurosim_spikes back in ft_read_header, (and in ft_read_data) -Never use ft_trialfun_general -Change ft_trialfun_general to fix this specific case (a bit of a hack).
Bart Gips - 2012-12-13 10:42:42 +0100
PS I'll have to commit the changes first. So the bug is not apparent yet.
Bart Gips - 2012-12-13 10:55:47 +0100
The bug should be reproducible as of revision 7161
Robert Oostenveld - 2012-12-13 18:05:52 +0100
I suggest -Put neurosim_spikes back in ft_read_header, (and in ft_read_data)
Bart Gips - 2012-12-14 10:47:23 +0100
(In reply to comment #3) bugfix - bug 1889 - Added filetype 'neurosim_spikes' to ft_read_data and ft_read _header. Sending contrib/spike/test/test_tutorial_spike_Neurosim.m Sending fileio/ft_read_data.m Sending fileio/ft_read_header.m Transmitting file data ... Committed revision 7193.
Diego Lozano Soldevilla - 2013-02-13 14:04:43 +0100
could it be that this is fixed? If so, please change status to Resolved-Fixed (and keep assignee as yourself).
Bart Gips - 2013-02-13 14:14:54 +0100
(In reply to comment #5) I seem to quite bad at actually finding the "resolved" button... Thanks for the heads-up.