Back to the main page.

Bug 1925 - surface_nesting.m and ft_headmodel_bemcp.m shell order backwards?

Reported 2013-01-14 15:52:00 +0100
Modified 2013-01-16 17:19:14 +0100
Product: FieldTrip
Component: forward
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P3 normal
Assigned to: Robert Oostenveld
Depends on:
See also:

Johanna - 2013-01-14 15:52:28 +0100

See also comment 15 in bug 1745. The labels in the code 'outsidefirst' and 'insidefirst' seem switched around. Or maybe I have the logic of this code backwards in my mind. Either way, the use of it from ft_headmodel_bemcp gives correct numerical output, even though the comments seem backwards as well. (i.e. requiring outsidefirst, but then later stating that skin must be shell 3).

Robert Oostenveld - 2013-01-14 16:37:24 +0100

I created a test script. It fails and the order is not consistent with the label. mac001> svn commit test_bug1925.m Adding test_bug1925.m Transmitting file data . Committed revision 7309. The bug affects the following mac001> grep surface_nesting *.m ft_headmodel_bemcp.m:order = surface_nesting(vol.bnd, 'outsidefirst'); ft_headmodel_dipoli.m:% order = surface_nesting(vol.bnd, 'outsidefirst'); ft_headmodel_dipoli.m:order = surface_nesting(vol.bnd, 'insidefirst'); ft_headmodel_openmeeg.m:order = surface_nesting(vol.bnd, 'insidefirst');

Robert Oostenveld - 2013-01-14 16:44:55 +0100

I have swapped the labels in the private function and the functions that call it. mac001> svn commit Sending forward/ft_headmodel_bemcp.m Sending forward/ft_headmodel_dipoli.m Sending forward/ft_headmodel_openmeeg.m Sending forward/private/surface_nesting.m Transmitting file data .... Committed revision 7310.

Robert Oostenveld - 2013-01-14 16:45:12 +0100

PS the same test script now works

Robert Oostenveld - 2013-01-16 17:19:14 +0100

closed bugs that were resolved.