Back to the main page.

Bug 1989 - find external functions that were downloaded from elsewhere and place them in external/misc

Status REOPENED
Reported 2013-02-17 13:30:00 +0100
Modified 2016-07-26 16:54:19 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P3 normal
Assigned to: Robert Oostenveld
URL:
Tags:
Depends on:
Blocks:
See also:

Robert Oostenveld - 2013-02-17 13:30:35 +0100

I was contacted by the author of CalcMD5, who pointed out that the BSD license clause to his function was not fulfilled. I have moved his function to external/misc and added the appropriate license. I expect that there are other functions in private directories that also suffer from license or copyright incompatibilities or errors. TODO: - search through all fieldtrip private directories for functions that originate from elsewhere (a.o. the arrowheads and uimagesg functions come to mind) - move them to fieldtrip/external/misc and add a copying (and optionally a readme) file Now that I think of it, some that predate the external directory alltogether are mentioned in fieldtrip/README The following files were downloaded from http://www.mathworks.com/matlabcentral/fileexchange uimage.m uimagesc.m arrow.m keep.m TODO: - update the fieldtrip/README file and remove the exceptions


Robert Oostenveld - 2013-03-17 20:05:08 +0100

this one does it r7685 | roboos | 2013-03-17 20:02:44 +0100 (Sun, 17 Mar 2013) | 1 line Merge branch 'master' of github.com:oostenveld/fieldtrip Again I failed in keeping the individual commits. The next time I'll follow the instructin here http://stackoverflow.com/questions/5673297/retaining-topic-branch-commits-with-git-svn-dcommit


Robert Oostenveld - 2013-04-23 12:05:53 +0200

closed various bugs


Robert Oostenveld - 2013-04-23 12:06:29 +0200

closed various bugs


Teresa Madsen - 2016-07-26 16:54:19 +0200

I've been getting a warning from uimage that would be easy to fix, but I realized it's an external function, so I have a couple questions: 1) I found this old bug about licenses and noticed that the uimage license is still missing, so I reopened it. I could copy the license from https://www.mathworks.com/matlabcentral/fileexchange/11368-uimage-uimagesc/all_files but then should I also copy the latest versions of the other files? The changes appear negligible: white space, semicolons, and comments only. 2) The latest version won't eliminate the warning I'm seeing, so I'm wondering if it's okay to fix, given this isn't a FieldTrip function. As far as I can tell, the license file doesn't seem to say anything about editing the code. It's not causing a problem yet (aside from annoying my perfectionistic tendencies), but looks like it may someday: Warning: NARGCHK will be removed in a future release. Use NARGINCHK or NARGOUTCHK instead. > In uimage (line 49) In uimagesc (line 28) In ft_plot_matrix (line 251) In ft_singleplotTFR (line 466) Warning: NARGCHK will be removed in a future release. Use NARGINCHK or NARGOUTCHK instead. > In uimage (line 49) In uimagesc (line 47) In ft_plot_matrix (line 254) In ft_singleplotTFR (line 466) The offending line, "error(nargchk(3,inf,nargin));" can be replaced by "narginchk(3,inf);"