Back to the main page.
Bug 1990 - something is broken with regards to grad.balance
| Status | CLOSED FIXED |
| Reported | 2013-02-18 09:56:00 +0100 |
| Modified | 2019-08-10 12:41:55 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P3 normal |
| Assigned to: | Diego Lozano Soldevilla |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: | http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=3229 |
Robert Oostenveld - 2013-02-18 09:56:36 +0100
I got the dashboard mail from 11 Feb. See http://fieldtrip.fcdonders.nl/development/dashboard The following tests have started failing since the last e-mail: test_bug1243 test_bug255 test_ft_topoplotER test_neuromag_units test_tutorial_clusterpermutationtimelock test_tutorial_eventrelatedstatistics The ones I checked all seem to fail due to Reference to non-existent field 'balance'. Does anyone of you know what may be causing it? It seems to be a problem introduced 5 or 6 revisions ago.
Jim Herring - 2013-02-18 10:40:10 +0100
Possibly related to bug1959 - http://bugzilla.fcdonders.nl/show_bug.cgi?id=1959 were an enhancement was added to use grad.balance in ft_sensetype to determine sens.type. I've added Diego to the CC as he committed the enhancement (rev. 7480)
Eelke Spaak - 2013-02-18 11:19:48 +0100
At the meeting, we discussed this, and thought it might also be related to bug 1977, as the test scripts concerned topo plotting, and that's what this bug was about. We could not look at the error message (involving 'balance') at the time though; with that info in mind possibly 1977 is not related after all.
Diego Lozano Soldevilla - 2013-02-18 15:12:04 +0100
(In reply to comment #2) I didn't ask for the field balance in grad structure: I assumed that was always present but it's not the case. Could someone confirm to me that the balance is only created after using ft_denoise_synthetic,ft_denoise_pca, ft_componentanalysis, ft_megplanar,ft_apply_montage? I run all test scripts that failed because my wrong fix and now all they worked fine: test_headmodel_singleshell_new_old test_bug1043 test_bug1212 test_bug131 test_leadfield_units test_ft_read_header test_bug1042 test_bug1043 test_bug131 Sending ft_senstype.m Transmitting file data . Committed revision 7488.
Diego Lozano Soldevilla - 2013-02-20 13:59:53 +0100
(In reply to comment #3) After bug-binge discussion with Robert, a test script will be created to: 1.Collect data types and 2.Potential balancing combinations: i.e. ica,pca,planar now the FT balancing schema is: FT high levet f(x) undobalancing ft_apply_montage Desired: FT high levet f(x) combine_montage ft_apply_montage old=input new=none combine_montage will deal with all the matrix balancing and ft_apply_montage will apply it to the data.
Robert Oostenveld - 2013-02-20 16:39:47 +0100
(In reply to comment #4) better call it convert_montage. It should be able to do for example comp_planar_GBR3_none -> planar_GBR3_none comp_planar_GBR3_none -> GBR3_none comp_planar_GBR3_none -> none
Robert Oostenveld - 2017-03-08 15:07:26 +0100
I consider it unlikely that the test script will come. Related to #3229 and https://github.com/fieldtrip/fieldtrip/pull/361 I made some changes. These will soon be merged and included in the release.
Robert Oostenveld - 2017-03-08 15:18:26 +0100
let me close this issue, as I think that https://github.com/fieldtrip/fieldtrip/pull/361 solves it. feel free to reopen and to make the case more clear.
Robert Oostenveld - 2019-08-10 12:35:42 +0200
This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.