Back to the main page.
Bug 2002 - ft_volumesegment is missing ambles (eg time consumption)
| Status | CLOSED FIXED |
| Reported | 2013-02-21 13:01:00 +0100 |
| Modified | 2014-06-18 12:34:27 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P3 normal |
| Assigned to: | Jan-Mathijs Schoffelen |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Jörn M. Horschig - 2013-02-21 13:01:14 +0100
haven't checked the code, but it's definitely never printing how much time it took
Jim Herring - 2014-01-23 10:40:46 +0100
Ambles were added in r7188, however, ft_volumegement calls a 'callinfo' amble which, I believe, has been merged into 'provenance' (see bug1892). The following functions still call 'callinfo': bash-4.1$ grep -r "postamble callinfo" ./* ./besa2fieldtrip.m:ft_postamble callinfo ./compat/.svn/text-base/ft_headmodelplot.m.svn-base:ft_postamble callinfo ./compat/ft_headmodelplot.m:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spiketriggeredaverage.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spikefixdmafile.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spikedownsample.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spike_plot_psth.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spikesplitting.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spike_psth.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spikedetection.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spike_select.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spiketriggeredspectrum_convol.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spikedensity.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spike_plot_isi.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spike_plot_isireturn.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spike_isi.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spikesimulation.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spiketriggeredinterpolation.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spike_waveform.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spike_plot_jpsth.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spikesorting.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spike_jpsth.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spike_rate_orituning.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spike_rate.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spiketriggeredspectrum_stat.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spike_xcorr.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spike_plot_raster.m.svn-base:ft_postamble callinfo ./contrib/spike/.svn/text-base/ft_spiketriggeredspectrum_fft.m.svn-base:ft_postamble callinfo ./contrib/spike/ft_spiketriggeredaverage.m:ft_postamble callinfo ./contrib/spike/ft_spikefixdmafile.m:ft_postamble callinfo ./contrib/spike/ft_spikedownsample.m:ft_postamble callinfo ./contrib/spike/ft_spike_plot_psth.m:ft_postamble callinfo ./contrib/spike/ft_spikesplitting.m:ft_postamble callinfo ./contrib/spike/ft_spike_psth.m:ft_postamble callinfo ./contrib/spike/ft_spikedetection.m:ft_postamble callinfo ./contrib/spike/ft_spike_select.m:ft_postamble callinfo ./contrib/spike/ft_spiketriggeredspectrum_convol.m:ft_postamble callinfo ./contrib/spike/ft_spikedensity.m:ft_postamble callinfo ./contrib/spike/ft_spike_plot_isi.m:ft_postamble callinfo ./contrib/spike/ft_spike_plot_isireturn.m:ft_postamble callinfo ./contrib/spike/ft_spike_isi.m:ft_postamble callinfo ./contrib/spike/ft_spikesimulation.m:ft_postamble callinfo ./contrib/spike/ft_spiketriggeredinterpolation.m:ft_postamble callinfo ./contrib/spike/ft_spike_waveform.m:ft_postamble callinfo ./contrib/spike/ft_spike_plot_jpsth.m:ft_postamble callinfo ./contrib/spike/ft_spikesorting.m:ft_postamble callinfo ./contrib/spike/ft_spike_jpsth.m:ft_postamble callinfo ./contrib/spike/ft_spike_rate_orituning.m:ft_postamble callinfo ./contrib/spike/ft_spike_rate.m:ft_postamble callinfo ./contrib/spike/ft_spiketriggeredspectrum_stat.m:ft_postamble callinfo ./contrib/spike/ft_spike_xcorr.m:ft_postamble callinfo ./contrib/spike/ft_spike_plot_raster.m:ft_postamble callinfo ./contrib/spike/ft_spiketriggeredspectrum_fft.m:ft_postamble callinfo ./fieldtrip2spss.m:ft_postamble callinfo ./ft_sourcemovie.m:ft_postamble callinfo ./ft_volumesegment.m:ft_postamble callinfo ./loreta2fieldtrip.m:ft_postamble callinfo ./nutmeg2fieldtrip.m:ft_postamble callinfo ./spass2fieldtrip.m:ft_postamble callinfo ./spm2fieldtrip.m:ft_postamble callinfo I'm sure it must be relatively easy to replace all occurrences of ft_postamble callinfo and ft_preamble callinfo to ft_preamble/ft_postamble provenance but I don't know how to do this.
Jim Herring - 2014-01-23 10:42:14 +0100
The following seems to correctly replace all occurrences but how can I commit all these files? find . -name "*.m" -print | xargs sed -i 's/ft_preamble callinfo/ft_preamble provenance/g' find . -name "*.m" -print | xargs sed -i 's/ft_postamble callinfo/ft_postamble provenance/g'
Jan-Mathijs Schoffelen - 2014-03-07 10:01:56 +0100
bash-4.1$ svn commit -m "enhancement - changed pre/postamble callinfo into provenance" ft_volumesegment.m ft_sourcemovie.m fieldtrip2spss.m loreta2fieldtrip.m nutmeg2fieldtrip.m spass2fieldtrip.m spm2fieldtrip.m Sending fieldtrip2spss.m Sending ft_sourcemovie.m Sending ft_volumesegment.m Sending loreta2fieldtrip.m Sending nutmeg2fieldtrip.m Sending spass2fieldtrip.m Sending spm2fieldtrip.m Transmitting file data ....... Committed revision 9270.