Back to the main page.

Bug 201 - Two defaults set for median filter order

Status CLOSED FIXED
Reported 2010-11-04 21:35:00 +0100
Modified 2010-12-08 11:41:42 +0100
Product: FieldTrip
Component: preproc
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P1 normal
Assigned to: Jan-Mathijs Schoffelen
URL:
Tags:
Depends on:
Blocks:
See also:

Ingrid Nieuwenhuis - 2010-11-04 21:35:15 +0100

In ft_preprocessing the default for the median filter is set (to 9), but in ft_preproc_medianfilter the default is set as well (to 25). It's not a real problem, since the default is not reset by ft_preproc_medianfilter, but it is a bit inconsistent. Better would be to have them the same, but what would be the better default to use? 9 or 25?


Robert Oostenveld - 2010-12-07 22:57:31 +0100

I think that ft_preproc_medianfilter should not have a default. It is something the experienced user (at the level of preproc) should be forced to think about.


Jan-Mathijs Schoffelen - 2010-12-08 11:41:37 +0100

I replaced the default of 25 by an explicit error in ft_preproc_medianfilter. This fixes and closes the bug