Back to the main page.
Bug 2094 - loreta missing?
| Status | CLOSED WONTFIX |
| Reported | 2013-04-05 13:53:00 +0200 |
| Modified | 2019-08-10 12:03:41 +0200 |
| Product: | FieldTrip |
| Component: | inverse |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P3 normal |
| Assigned to: | |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Johanna - 2013-04-05 13:53:48 +0200
I can't find the function 'loreta.m' that would get called if cfg.method='loreta' on line 893 of ft_sourceanalysis. I can't find it in any private or external directory. Below is a test script. load standard_bem load dataFIC cfg=[]; cfg.method='singlesphere'; vol1=ft_prepare_headmodel(cfg,vol.bnd(1)); cfg=[]; cfg.covariance='yes'; cfg.covariancewindow='all'; tlock=ft_timelockanalysis(cfg,dataFIC) cfg=[]; cfg.method='loreta'; cfg.grad=tlock.grad; cfg.vol=vol1; source=ft_sourceanalysis(cfg,tlock); ??? Undefined function or method 'loreta' for input arguments of type 'struct'. Error in ==> ft_sourceanalysis at 893 dip(i) = loreta(grid, sens, vol, squeeze_avg, optarg{:});
Robert Oostenveld - 2013-04-12 08:58:08 +0200
On 11 Apr 2013, at 22:16, Ingrid Nieuwenhuis wrote: Is die implementatie ooit afgemaakt en getest? In de help van ft_sourceanalysis leek het of ie af was en in FieldTrip zit, maar loreta.m is er niet, en in de help lijst archief zag ik in 2010 dat ie nog niet af was.
Robert Oostenveld - 2013-04-12 09:00:35 +0200
the implementation of loreta was never really finished 100%. And it was the smoothness constraint-based loreta, not sloreta or elotera. Nowadays sloreta would make sense to implement. I will remove the remains of the code and documentation. Perhaps we can get it implemented for sloreta using the nutmeg version. That depends on the redesign of the interface to the inverse functions, see bug 208.
Robert Oostenveld - 2013-04-12 09:05:04 +0200
I made the chanegs in a git branch on my desktop computer. mac001> git merge bug2094-loreta Updating 156fba7..6048ba8 Fast-forward ft_sourceanalysis.m | 11 ++--------- utilities/ft_checkconfig.m | 2 +- 2 files changed, 3 insertions(+), 10 deletions(-) mac001> git push oostenveld master Warning: untrusted X11 forwarding setup failed: xauth key data not generated Warning: No xauth data; using fake authentication data for X11 forwarding. Counting objects: 9, done. Delta compression using up to 4 threads. Compressing objects: 100% (5/5), done. Writing objects: 100% (5/5), 517 bytes, done. Total 5 (delta 4), reused 0 (delta 0) To git@github.com:oostenveld/fieldtrip.git 156fba7..6048ba8 master -> master mac001> git push fieldtrip master Warning: untrusted X11 forwarding setup failed: xauth key data not generated Warning: No xauth data; using fake authentication data for X11 forwarding. Counting objects: 9, done. Delta compression using up to 4 threads. Compressing objects: 100% (5/5), done. Writing objects: 100% (5/5), 517 bytes, done. Total 5 (delta 4), reused 0 (delta 0) To git@github.com:fieldtrip/fieldtrip.git 156fba7..6048ba8 master -> master At the moment I am having some git/svn merge issues, but soon it will also be on the svn and release version.
Johanna - 2013-04-17 12:43:25 +0200
(In reply to comment #2) I would be happy to help with bringing in sloreta (from nutmeg) once the interface for inverse is updated. Should we make a new bug of that (and close this one), or make this the new purpose of this bug?
Robert Oostenveld - 2013-04-17 12:58:01 +0200
(In reply to comment #4) there is already one for that, see bug 208.