Back to the main page.
Bug 2184 - settle on convention for upper/lower case method names
| Status | CLOSED FIXED |
| Reported | 2013-06-03 12:13:00 +0200 |
| Modified | 2019-08-10 12:41:17 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P3 enhancement |
| Assigned to: | |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Jörn M. Horschig - 2013-06-03 12:13:36 +0200
Could we settle on defining method names always lowercase and convert to lower case if the user specifies them with upper case? I just bumped into an error in ft_checkconfig, line 279, that creates a subcfg with switch subname. However, a switch-statement is case-sensitive so e.g. ft_sourceanalysis with cfg.method = 'LCMV' to crashes with: Error using ft_checkconfig (line 437) unexpected name of the subfunction When defining cfg.method = 'lcmv' instead it works fine. The error message I got is really unspecific, a FT beginner might get totally confused by this. Alternatively, the error message might be extended and hint to case sensitivity.
Robert Oostenveld - 2013-06-03 16:08:29 +0200
I don't think that we should be modifying the users configuration, unless we know that it has to be updated to reflect changes in the code which we introduced ourselves. We do not want to take the responsibility out of the users hands. However, in this case I do see the convention of spelling the abbreviations in uppercase and our use of them in lower case. I suggest to add "ft_checkconfig renamed LCMV into lcmv" at the beginning of ft_sourceanalysis.
Jörn M. Horschig - 2013-06-05 10:36:28 +0200
isn't that the case for all methods of ft_sourceanalysis, because they are abbreviations? If so, then it would be easier to make cfg.method = lower(cfg.method) rather than have a bunch of ft_checkconfig renamed statements
Jan-Mathijs Schoffelen - 2017-01-17 11:15:55 +0100
It's unclear what the status of this one is, but given the fact that we're severely underpowered in terms of people contributing to fixing issues on bugzilla, Robert and JM have decided to close the low-priority bugs for now. This in order to keep the number of open bugs manageable. Feel free to reopen it, if you are willing to move this one forward towards a more proper resolution.
Robert Oostenveld - 2019-08-10 12:35:06 +0200
This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.