Back to the main page.
Bug 2186 - ft_appendtimelock: some bugs and documentation needs
| Status | CLOSED FIXED |
| Reported | 2013-06-04 15:12:00 +0200 |
| Modified | 2019-08-10 12:41:15 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P3 normal |
| Assigned to: | Robert Oostenveld |
| URL: | |
| Tags: | |
| Depends on: | 3287 |
| Blocks: | |
| See also: | http://bugzilla.fcdonders.nl/show_bug.cgi?id=2513http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=2285http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=2187http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=1984 |
Johanna - 2013-06-04 15:12:01 +0200
1) Add documentation of what cfg options possible. Seems to me only cfg.channel. 2) Line 102 says .cov(:,chanselchansel) but should be .cov(:,chansel,chansel). Very surprising that this bug was introduced in Nov 2011 and no one reported it between then and now! 3) If timelock structures all have a .trial (and automatically .avg field), then the .avg fields should be removed, a new .trial created based on concatenation over trials (as is done); but then also a new .avg and new .var should be created based on this new .trial. Although .avg is not considered a required field for a timelock structure, ft_sourceanalysis requires .avg (although maybe shouldn't?!) even if .trial exists. Alternatively, the user can compute .avg themself after append prior to sourceanalysis, but should FT require this of them? See also bug 1495.
Johanna - 2013-06-06 15:07:57 +0200
Fixed in svn r8215 and 8216.
Johanna - 2013-06-06 17:58:06 +0200
I seem to have broken test_bug1014 with the change I made to fix point (3) in the Description of this bug. this other test function does not want an average.
Robert Oostenveld - 2017-04-21 10:21:25 +0200
Arjen implemented ft_append_sens and made changes to ft_append_data. This made the inconsistency between appending data/timelock/freq very obvious. Please note that there is also an ft_appendsource, but I won't be looking at that one now.
Robert Oostenveld - 2017-04-25 14:44:03 +0200
mac011> git commit -a [master 8a05c7d] ENH - this implements appending of covariance matrices, see also http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=2186 3 files changed, 92 insertions(+), 12 deletions(-) create mode 100644 test/test_bug2186.m I implemented appending of the covariance and added a test script.
Robert Oostenveld - 2019-08-10 12:35:04 +0200
This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.