Back to the main page.
Bug 2191 - ft_selectdata (new vs old) avgoverchan: mean or sum?
Status | CLOSED FIXED |
Reported | 2013-06-07 14:01:00 +0200 |
Modified | 2019-08-10 12:03:09 +0200 |
Product: | FieldTrip |
Component: | core |
Version: | unspecified |
Hardware: | PC |
Operating System: | Windows |
Importance: | P3 trivial |
Assigned to: | Diego Lozano Soldevilla |
URL: | |
Tags: | |
Depends on: | |
Blocks: | 1021 |
See also: |
Johanna - 2013-06-07 14:01:45 +0200
There was a bug in the way that data.label was updated when cfg.avgoverchan='yes' for ft_selectdata_new. The {} were missing, so that data.label was not a cell array. I have fixed that (r8220). It is correct in ft_selectdata_old. But in fixing it, I noticed the actual label is different between new and old. For example: (in new) "chan001+chan002+chan003" Versus (in old) "mean(chan001, chan002, chan003)" Isn't the old way correct, since it is actually a mean, not a sum, over channels? The old uses a utilities/private function 'avgoverlabel' to do this.
Johanna - 2013-06-07 14:02:48 +0200
Btw, thanks to Sebastiaan for finding the bug.
Jan-Mathijs Schoffelen - 2013-08-07 13:09:49 +0200
please use old-style
Diego Lozano Soldevilla - 2013-08-15 12:27:47 +0200
fixed and committed Sending ft_selectdata_new.m Transmitting file data . Committed revision 8397. Sending test_ft_selectdata.m Transmitting file data . Committed revision 8398.