Back to the main page.
Bug 2208 - implement drop-in replacement function for finv
| Status | CLOSED FIXED |
| Reported | 2013-06-23 13:19:00 +0200 |
| Modified | 2014-01-29 13:28:34 +0100 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P3 normal |
| Assigned to: | Eelke Spaak |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: | http://bugzilla.fcdonders.nl/show_bug.cgi?id=2033 |
Robert Oostenveld - 2013-06-23 13:19:41 +0200
at the EEGLAB workshop we noticed (with a participant that did not have the stats toolbox) that there is no statfun/private/finv function. It should be possible to find a replacement function somewhere
Eelke Spaak - 2013-08-21 14:37:01 +0200
I'll copy the version from Octave over
Robert Oostenveld - 2013-08-21 14:40:22 +0200
mac001> svn commit Adding external/stats Adding external/stats/README Transmitting file data . Committed revision 8408.
Robert Oostenveld - 2013-08-21 14:56:40 +0200
mac001> find . -name \*.m -exec basename {} .m \; | sort | uniq > out1 mac001> find /Applications/MATLAB_R2012b.app/toolbox/stats -name \*.m -exec basename {} .m \; | sort | uniq > out2 The following lists the lines that are present in both files, i.e. both in fieldtrip (somewhere) and in the stats toolbox. mac001> comm -1 -2 out1 out2 Contents binocdf binopdf checkdata children disp display distchck end hline idummy logit nanmean nanstd nansum nanvar parent pca plot randsample range subsasgn subsref tcdf termcross test tinv view vline I did it again, now excluding all files in fieldtrip/external mac001> comm -1 -2 out1 out2 Contents binocdf binopdf checkdata display hline nanmean nanstd nansum nanvar randsample range subsasgn subsref tcdf test tinv vline not all are meant to be compatible, but some are. Could you also move those to external/stats and remove them altogether from other FT locations?
Eelke Spaak - 2013-08-21 15:25:21 +0200
I added finv with its dependencies (r8409). I don't fully understand the list you put here. After filtering out stuff that is private to the stats toolbox (e.g. display, checkdata) or part of matlab builtin (e.g. subsasgn, subsref) I'm left with this list: binocdf binopdf hline nanmean nanstd nansum nanvar randsample range tcdf tinv vline I will move these to external/stats, or get them from octave and add the replacement. Also, I will make sure ft_defaults adds external/stats to the path.
Eelke Spaak - 2013-08-21 15:27:34 +0200
Note: I've left the original Octave copyright and GPL notices intact. This seemed most appropriate to me, especially since the files will be in /external/ anyway.
Eelke Spaak - 2013-08-21 16:18:18 +0200
fixed as of 8411
Eelke Spaak - 2013-08-21 16:19:05 +0200
Note: I have left the nan* mex-files also in /src/, but removed them from everywhere else.