Back to the main page.
Bug 2353 - rename scalingfactor into ft_scalingfactor and move from private to utilities
| Status | CLOSED FIXED |
| Reported | 2013-10-31 12:16:00 +0100 |
| Modified | 2016-06-14 16:14:53 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P3 normal |
| Assigned to: | Robert Oostenveld |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Robert Oostenveld - 2013-10-31 12:16:38 +0100
this allows Vladimir to use it in SPM
Guillaume - 2016-01-07 17:18:34 +0100
It seems this was implemented in r11035 and r11039 but there are still mentions of the old syntax in, eg, fileio/ft_read_data.m and ft_scalingfactor.m itself: fieldtrip/fileio/ft_read_data.m: l.1345: scaling = cellfun(@scalingfactor, hdr.chanunit(chanindx(:)), chanunit(:)); fieldtrip/utilities/ft_scalingfactor.m: l.92: factor = cellfun(@scalingfactor, old(:), new(:));
Robert Oostenveld - 2016-01-07 18:05:16 +0100
Sorry, I forgot to mention the commit here. My grep missed them. The fieldtrip/compat/scalingfactor.m function should catch it, but of course needs to be fixed. mac011> svn commit Sending fileio/ft_read_data.m Sending ft_prepare_headmodel.m Sending test/test_bug2570.m Sending test/test_scalingfactor.m Transmitting file data .... Committed revision 11042. mac011> svn commit Sending utilities/ft_scalingfactor.m Transmitting file data . Committed revision 11043.
Robert Oostenveld - 2016-01-07 18:05:32 +0100
I think it is now fixed.
Robert Oostenveld - 2016-01-09 18:12:05 +0100
(In reply to Guillaume from comment #1) I just noticed that I forgot to add this one to the release (although I mentioned it in a previous comment). That caused Guillame noticing that it was renamed. I'll still add it, just to be sure. mac011> svn commit Adding compat/scalingfactor.m Transmitting file data . Committed revision 11051.