Back to the main page.

Bug 2439 - improve documentation for ft_determine_coordsys

Status CLOSED FIXED
Reported 2014-01-17 11:11:00 +0100
Modified 2014-06-18 12:32:58 +0200
Product: FieldTrip
Component: documentation
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P5 minor
Assigned to: Jan-Mathijs Schoffelen
URL:
Tags:
Depends on:
Blocks:
See also:

Robert Spangler - 2014-01-17 11:11:06 +0100

In a discussion with Robert O and Robert S we figured out that there is http://fieldtrip.fcdonders.nl/faq/how_are_the_different_head_and_mri_coordinate_systems_defined but it does not mention ft_determine_coordsys


Jan-Mathijs Schoffelen - 2014-04-16 14:01:13 +0200

Discussing this FT-meeting (actually in relation to the cfg-option coordsys). The cfg.coordsys should be removed from the documentation and code, (apart from ft_volumerealign), because it does not refer to the computation, but reflects a property of the data.


Jan-Mathijs Schoffelen - 2014-04-17 10:18:24 +0200

working on this I encountered a bunch of annoying problems (when checkconfig is pedantic) related to a lot of the code still implicitly checking for a cfg.coordsys: ft_sourceplot ft_volumenormalise ft_volumesegment The latter two have a call to ft_checkdata with 'hascoordsys' 'yes', ft_sourceplot hasn't. I will build this into ft_sourceplot. This however will force the user to go through ft_determine_coordsys if he/she omits a data.coordsys.


Robert Oostenveld - 2014-04-18 19:21:00 +0200

test_ft_volumesegment started failing because ft_determine_coordsys would not get an interactive answer. This is probably related to https://code.google.com/p/fieldtrip/source/detail?r=9442 I changed the test script into using mri.coordsys instead. roboos@mentat001> svn commit test/ Sending test/test_ft_volumesegment.m Transmitting file data . Committed revision 9445.


Jan-Mathijs Schoffelen - 2014-05-27 15:09:26 +0200

I updated the faq that describes the coordinate systems with a paragraph that mentions ft_determine_coordsys and its purpose