Back to the main page.
Bug 2538 - update all calls to ft_selectdata_old to use the common (newer) implementation
| Status | CLOSED FIXED |
| Reported | 2014-04-15 19:06:00 +0200 |
| Modified | 2016-01-15 09:37:18 +0100 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P3 normal |
| Assigned to: | Jan-Mathijs Schoffelen |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | 1021 |
| See also: |
Robert Oostenveld - 2014-04-15 19:06:57 +0200
the following functions use old syntax with multiple input arguments. ft_appendsource.m ft_freqstatistics.m ft_freqstatistics.m ft_multiplotER.m ft_multiplotER.m ft_multiplotER.m ft_singleplotER.m ft_singleplotER.m ft_sourcestatistics.m
Robert Oostenveld - 2014-04-15 19:07:41 +0200
the following functions use the old syntax for selecting trials in a single data structure. ft_channelnormalise.m ft_channelrepair.m ft_componentanalysis.m ft_connectivityanalysis.m ft_denoise_pca.m ft_denoise_pca.m ft_denoise_synthetic.m ft_freqanalysis.m ft_freqdescriptives.m ft_megplanar.m ft_megrealign.m ft_preprocessing.m ft_redefinetrial.m ft_rejectvisual.m ft_resampledata.m ft_scalpcurrentdensity.m ft_timelockanalysis.m
Robert Oostenveld - 2014-04-15 19:12:54 +0200
the following functions have another use of the old implementation (foilim, toilim, channels, jackknife?). ft_connectivityanalysis.m ft_freqanalysis.m ft_freqdescriptives.m ft_qualitycheck.m
Jan-Mathijs Schoffelen - 2014-04-15 20:33:59 +0200
Shoot. Forgot about Jackknife altogether. What do you think, is anybody using that functionality?
Robert Oostenveld - 2014-06-12 19:36:48 +0200
mac011> svn commit ft_selectdata*m ft_selectdata_newer.m Sending ft_selectdata_new.m Deleting ft_selectdata_newer.m Sending ft_selectdata_old.m Transmitting file data .. Committed revision 9620. I removed the newer implementation, it has been fused with the proper one. I also removed the end-user documentation for old and new version, instead it now states that it is deprecated and that ft_selectdata is to be used.
Jan-Mathijs Schoffelen - 2015-02-12 09:22:04 +0100
As of today, the following high-level ft-functions still use the old version: ft_appendsource ft_connectivityanalysis ft_freqdescriptives ft_multiplotER ft_qualitycheck ft_singleplotER
Jan-Mathijs Schoffelen - 2015-02-12 09:23:38 +0100
Some of the functions mentioned in the previous comment are straightforward, the 'jackknife' option in the old implementation is used in ft_connectivityanalysis and ft_freqdescriptives (for the latter it is easy to solve).
Jan-Mathijs Schoffelen - 2015-02-12 09:28:39 +0100
$ svn commit -m "enhancement - use ft_selectdata 'new'" ft_qualitycheck.m Sending ft_qualitycheck.m Transmitting file data . Committed revision 10220.
Jan-Mathijs Schoffelen - 2015-09-14 10:22:45 +0200
ft_selectdata 'new' is now also used in ft_singleplotER.m and ft_multiplotER.m The only occurrences in high-level FT-functions are now: ft_appendsource ft_freqdescriptives and ft_connectivityanalysis (for jackknifing).
Jan-Mathijs Schoffelen - 2015-09-15 11:56:18 +0200
ft_freqdescriptives does the jackknifing inline, instead of relying on ft_selectdata_old, as of revision 10670, as discussed in the FT-meeting.
Jan-Mathijs Schoffelen - 2015-09-15 16:08:02 +0200
ft_connectivityanalysis now also only uses ft_selectdata (new). (revision 10672)
Jan-Mathijs Schoffelen - 2015-09-15 16:41:53 +0200
Also removed call to ft_selectdata (old) in ft_appendsource. This for sure breaks this function, but I think that this one didn't work to begin with. I suggest to follow this up elsewhere. This bug can be closed I think.