Back to the main page.
Bug 254 - call to checkdata in functions like topoplotER/TFR should be based on dimord
| Status | CLOSED FIXED |
| Reported | 2010-12-01 16:23:00 +0100 |
| Modified | 2012-02-06 15:40:34 +0100 |
| Product: | FieldTrip |
| Component: | plotting |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P1 normal |
| Assigned to: | Roemer van der Meij |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Roemer van der Meij - 2010-12-01 16:23:19 +0100
At the moment, checkdata checks whether the input is freq, timelock or comp data (in the case of topoplotER/TFR). This should ideally work by only checking whether the absolutely necessary dimension is present in the data. For topoplotER/TFR this is the 'chan' dimension, which can be extracted from the dimord. For multiplotER this would be 'chan' as well and 'time'/'freq'/etc, andsoforth for the other functions. This will most likely require changes in ft_checkdata, but I do not have the oversight to know for sure (e.g. I don't think it accepts multiple dimords, dimords with wild-cards, etc).
Roemer van der Meij - 2011-09-21 17:18:08 +0200
Unassigning, I believe this has changed in the meantime already?
Jan-Mathijs Schoffelen - 2011-10-03 14:04:41 +0200
If it has been already addressed: please check whether it all works and set the status to fixed and eventually close it
Roemer van der Meij - 2012-02-01 16:59:53 +0100
It is fixed, ft_datatype now properly checks for the necessary dimensions only (at least in the case of freq, where it failed in some cases).
Boris Reuderink - 2012-02-03 16:28:17 +0100
Hi Roemer, can you find the commit before I close this issue?
Roemer van der Meij - 2012-02-06 11:30:59 +0100
Oooh, I have no idea. It was fixed a long time ago by JM. I can look through the logs, but that seems like a waste of time. Issue is fixed and checked, so it can be closed.