Back to the main page.

Bug 2567 - add subfunctions isrow and iscolumn to ft_selectdata

Reported 2014-05-08 13:59:00 +0200
Modified 2015-07-09 14:23:16 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P5 normal
Assigned to: Robert Oostenveld
Depends on:
See also:

Jörn M. Horschig - 2014-05-08 13:59:46 +0200

because these functions do not exist in matlab < 2010 Robert suggested to create subfunctions for this. An alternative would be to check size(X, 1)>1 or size(X, 2)>1, see bug 1879

Robert Oostenveld - 2014-05-11 08:49:03 +0200

mac011> svn commit Adding iscolumn.m Adding isrow.m Transmitting file data .. Committed revision 9477.

Robert Oostenveld - 2014-05-11 08:52:21 +0200

I hope it does not result in a lot of warnings. I now get these: >> [msg,id] = lastwarn msg = Function isrow has the same name as a MATLAB builtin. We suggest you rename the function to avoid a potential name conflict. id = MATLAB:dispatcher:nameConflict If this gets annoying, we should switch this warning off, or move the functions as sub functions into ft_selectdata.

Robert Oostenveld - 2014-05-11 10:14:35 +0200

(In reply to Robert Oostenveld from comment #2) MATLAB indeed got noisy with warnings. I changed them int subfunctions. roboos@mentat001> svn commit Sending utilities/ft_selectdata.m Deleting utilities/private/iscolumn.m Deleting utilities/private/isrow.m Transmitting file data . Committed revision 9478.

Robert Oostenveld - 2014-05-14 20:08:47 +0200

closed several of my bugs that have been resolved

Robert Oostenveld - 2015-07-09 14:23:16 +0200

I removed the sub functions, bug 2922 solves it in a better manner. ub246233> svn commit utilities/ft_selectdata.m Sending utilities/ft_selectdata.m Transmitting file data . Committed revision 10527.