Back to the main page.
Bug 2579 - ft_source* functions should gracefully deal with cfg.parameter containing either avg.XX or XX
| Status | CLOSED FIXED |
| Reported | 2014-05-14 13:56:00 +0200 |
| Modified | 2019-08-10 12:28:41 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P5 normal |
| Assigned to: | Eelke Spaak |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: | http://bugzilla.fcdonders.nl/show_bug.cgi?id=2556 |
Jan-Mathijs Schoffelen - 2014-05-14 13:56:13 +0200
see http://mailman.science.ru.nl/pipermail/fieldtrip/2014-May/007929.html
Eelke Spaak - 2014-05-14 17:26:08 +0200
bash-4.1$ svn commit ft_sourcegrandaverage.m Sending ft_sourcegrandaverage.m Transmitting file data . Committed revision 9526. fixed for ft_sourcegrandaverage Still to do: - ft_sourcestatistics - ft_sourceplot - ft_volumewrite - ft_sourceinterpolate - possibly others, search for cfg.parameter
Robert Oostenveld - 2014-05-20 21:08:12 +0200
I made a commit today related to this for bug #2556.
Eelke Spaak - 2014-05-22 14:49:17 +0200
Actually, after some searching and fiddling, it turns out that none of the other functions need a change to fix this bug. The bug only occurs when a function both (1) has a cfg.parameter input and (2) internally converts the data to the 'upcoming' source representation. This conjunction was only true for ft_sourcegrandaverage. It should be noted that when in the (hopefully near) future other source functions get updated to explicitly use the 'upcoming' source representation, this bug will thus reappear. The changes I made to ft_sourcegrandaverage should be generally applicable: https://code.google.com/p/fieldtrip/source/diff?spec=svn9526&r=9526&format=side&path=/trunk/ft_sourcegrandaverage.m