Back to the main page.
Bug 2591 - ft_databrowser does not handle cfg.*scale for opt.curdat
| Status | CLOSED FIXED |
| Reported | 2014-05-23 12:29:00 +0200 |
| Modified | 2019-08-10 12:28:33 +0200 |
| Product: | FieldTrip |
| Component: | plotting |
| Version: | unspecified |
| Hardware: | All |
| Operating System: | All |
| Importance: | P5 major |
| Assigned to: | |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: | http://bugzilla.fcdonders.nl/show_bug.cgi?id=2588 |
Thomas Hartmann - 2014-05-23 12:29:47 +0200
hi, in line 1481 of ft_databrowser, the data that was read in and prepared previously is put in opt.curdat. only later scaling is applied. this breaks identifying channels as this is working on the unscaled opt.curdat although (the scaled) dat is displayed. so, i would suggest that either identifying channels should work directly on dat or opt.curdat should contain scaled data. as i am not familiar with the internal workings, i do not know which of these solutions is better. maybe you prefer a third solution? best, thomas
Robert Oostenveld - 2014-05-23 13:26:14 +0200
probably it was implemented completely disjoint, i.e. one person at one location in the code not thinking about the code that someone else added elsewhere. Could you try whether scaling opt.curdat works?
Thomas Hartmann - 2014-05-23 14:36:11 +0200
(In reply to Robert Oostenveld from comment #1) yeah, that works great. in fact, i just moved the creation of 'opt.curdat' after the scaling block and it works great. i created a push request here: https://github.com/fieldtrip/fieldtrip/pull/42
Robert Oostenveld - 2014-05-27 13:19:48 +0200
(In reply to Thomas Hartmann from comment #2) mac011> patch -p1 < patch patching file ft_databrowser.m Hunk #1 succeeded at 1484 (offset 6 lines). Hunk #2 succeeded at 1525 (offset 6 lines). mac011> svn commit ft_databrowser.m Sending ft_databrowser.m Transmitting file data . Committed revision 9590.