Back to the main page.
Bug 2620 - ft_multiplotER ignores the cfg.showoutline option and always plots it
| Status | CLOSED FIXED |
| Reported | 2014-06-20 13:59:00 +0200 |
| Modified | 2019-08-10 12:29:24 +0200 |
| Product: | FieldTrip |
| Component: | plotting |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P5 normal |
| Assigned to: | Tzvetan Popov |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Robert Oostenveld - 2014-06-20 13:59:15 +0200
There is a piece of code that plots the outline on line 391. This is not conditional on the cfg. Subsequently, on line 582 the outline is plotted once more in case show outline=yes. Tineke conformed having seen cartoon heads in ERFs during the last 2 years, although according to the cfg.showoutline default there should not be any. Also the plotting tutorial has a figure without outline. I traced it down to https://code.google.com/p/fieldtrip/source/detail?r=3694 which was on 15 June 2011.
Robert Oostenveld - 2014-06-20 14:02:19 +0200
The code section from critic needs to be removed. Howevere, in the last 3 years the defaults and hence most figures have been different for ER and TFR. I want them to be consistent. Should we switch cfg.showoutline=yes in both?
Tzvetan Popov - 2014-09-10 15:03:53 +0200
I started addressing this bug. I'll make a test script to reproduce it.
Tzvetan Popov - 2014-09-10 15:09:08 +0200
bash-4.1$ svn commit Adding test/test_bug2620.m Transmitting file data . Committed revision 9784.
Tzvetan Popov - 2014-09-11 09:58:36 +0200
I adjusted the behavior of ft_mulitplotER to be the same like the on of ft_multiplotTFR with respect to cfg.showoutline. Sending ft_multiplotER.m Transmitting file data . Committed revision 9790.
Tzvetan Popov - 2014-09-11 09:59:21 +0200
Set status to resolved