Back to the main page.

Bug 2727 - ft_clusterplot has regression error due to change in r9830

Status CLOSED FIXED
Reported 2014-10-07 15:52:00 +0200
Modified 2019-08-10 12:29:31 +0200
Product: FieldTrip
Component: plotting
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P5 normal
Assigned to: Tzvetan Popov
URL:
Tags:
Depends on:
Blocks:
See also:

Robert Oostenveld - 2014-10-07 15:52:02 +0200

I noticed that test_tutorial_plotting is failing. I suspect it to be due to the following. r9830 | jorhor | 2014-09-24 14:25:31 +0200 (Wed, 24 Sep 2014) | 1 line bugfix&enhancement - multiple figures are opened again, and it's possible to show channel_frequency data now (though hacked, implementation could have been nicer)


Robert Oostenveld - 2014-10-07 15:53:36 +0200

this fixes it for the test script. I also cleaned it up a bit. mac011> svn commit ft_clusterplot.m Sending ft_clusterplot.m Transmitting file data . Committed revision 9888. @jorn, I hope it still works for you.


Robert Oostenveld - 2014-10-07 16:09:51 +0200

I also noticed that test_tutorial_clusterpermutationfreq had started failing on the dashboard, probably due to the same cause in ft_clusterplot.


Robert Oostenveld - 2014-11-12 18:11:14 +0100

it turns out that the commit by Jorn (r9830) and subsequent commit by Robert (r9888) have left the function in a state that is not completely as desired. This was detected in bug 2745.


Tzvetan Popov - 2014-11-12 18:11:46 +0100

*** Bug 2745 has been marked as a duplicate of this bug. ***


Robert Oostenveld - 2014-11-12 18:14:27 +0100

I added a test script that demonstrates the problem, it is not yet resolved. mac011> svn commit test_bug2727.m Adding test_bug2727.m Transmitting file data . Committed revision 9959.


Tzvetan Popov - 2014-11-19 10:30:25 +0100

bash-4.1$ svn commit test_bug2727.m -m 'removed multiple figure calls' Sending test_bug2727.m Transmitting file data . Committed revision 9973.


Tzvetan Popov - 2014-11-19 10:34:20 +0100

bash-4.1$ svn commit ft_clusterplot.m -m 'bugfix: fixed disabled plotting of multiple time points see http://bugzilla.fcdonders.nl/show_bug.cgi?id=2727 ' Sending ft_clusterplot.m Transmitting file data . Committed revision 9974.


Robert Oostenveld - 2019-08-10 12:29:31 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue describing the issue on https://github.com/fieldtrip/fieldtrip/issues.