Back to the main page.

Bug 2742 - prevent power from being removed as 'probabilistic' field

Status CLOSED FIXED
Reported 2014-10-18 18:14:00 +0200
Modified 2015-02-11 10:40:34 +0100
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P5 normal
Assigned to: Robert Oostenveld
URL:
Tags:
Depends on:
Blocks:
See also:

Robert Oostenveld - 2014-10-18 18:14:44 +0200

This was discussed over email with Giorgos. I made the commit mac011> svn commit utilities/ Sending utilities/ft_checkdata.m Sending utilities/ft_datatype_parcellation.m Sending utilities/ft_datatype_segmentation.m Sending utilities/private/determine_segmentationstyle.m Transmitting file data .... Committed revision 9911. but now there are regression problems with test_bug1646 test_bug1651 test_bug1652 test_bug1756 test_bug1764 test_bug1832 test_bug1954 test_bug2397 test_ft_electroderealign test_tutorial_beamformer test_tutorial_beamformer20120321 test_tutorial_beamformer20131122 test_tutorial_beamformingextended test_tutorial_beamformingextended20131122 test_tutorial_headmodel_eeg test_tutorial_headmodel_meg I did not check all of them, but some are failing to make a brain mask on the fly (which was indeed code that was affected by my change).


Robert Oostenveld - 2014-10-18 18:15:26 +0200

this needs to be resolved before the next megconnectome release candidate can be compiled.


Robert Oostenveld - 2014-10-19 09:13:32 +0200

I suspect that the issue is completely explained by the new code (as of yesterday) not working only on segmentation/parcellation, but also on other fields (such as dim, cfg). I now remove these fields prior to doing the checks on the segmentation/parcellation. roboos@mentat001> svn commit utilities/ Sending utilities/ft_datatype_parcellation.m Sending utilities/ft_datatype_segmentation.m Transmitting file data .. Committed revision 9916. I will postpone recompilation until I see the regression test results on the dashboard.


Robert Oostenveld - 2014-10-19 12:28:35 +0200

dashboard looks good, I compiled megconnectome 2.2-rc5 with fieldtrip r9919.


Robert Oostenveld - 2015-02-11 10:40:34 +0100

Closed several bugs that were recently resolved. Please reopen if you are not happy with the resolution.