Back to the main page.

Bug 2748 - Redundant or unnecessary work in ft_sourceanalysis

Reported 2014-10-27 22:08:00 +0100
Modified 2019-08-10 12:31:25 +0200
Product: FieldTrip
Component: core
Version: unspecified
Hardware: PC
Operating System: Windows
Importance: P5 enhancement
Assigned to: Eelke Spaak
Depends on:
See also:

Marc Lalancette - 2014-10-27 22:08:19 +0100

Trivial, but the check at line 1029 in ft_sourceanalysis is redundant with the if block just above it: if (strcmp(cfg.jackknife, 'yes') || strcmp(cfg.bootstrap, 'yes') || strcmp(cfg.pseudovalue, 'yes') || strcmp(cfg.singletrial, 'yes') || strcmp(cfg.rawtrial, 'yes')) && strcmp(cfg.keeptrials, 'yes') % keep the source reconstruction for each repeated or resampled trial source.trial = dip; end

Eelke Spaak - 2015-01-27 15:35:07 +0100

(In reply to Marc Lalancette from comment #0) Indeed, now fixed. bash-4.1$ svn commit ft_sourceanalysis.m Sending ft_sourceanalysis.m Transmitting file data . Committed revision 10130.

Robert Oostenveld - 2019-08-10 12:31:25 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on