Back to the main page.
Bug 2749 - ft_source2full fails when dealing with Nvox x Nvox data
| Status | CLOSED FIXED |
| Reported | 2014-10-30 12:51:00 +0100 |
| Modified | 2019-08-10 12:29:41 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Linux |
| Importance: | P5 normal |
| Assigned to: | Tzvetan Popov |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Tzvetan Popov - 2014-10-30 12:51:26 +0100
When the input data has a field 'cohspctrm' the function fails on line 162 because it loops over 'param'. Yet param has field 'inside' 'cohspctrm' and 'pos' but at that stage only the 'inside' part is actually relevant because the others are computed below. on line 151 I added this: ---------- ind=find(ismember(param,'inside'));% find the index of 'inside' field % because its position varies with isfield('plvspctrm') vs. 'cohspctrm' param = param(sel(ind)); ---------- so that param at that stage is always 'inside'. Any objections?
Robert Oostenveld - 2014-10-30 13:14:32 +0100
I think that ft_source2full and source2sparse have to be fully revamped, consistently making use of the new style but now also using getdimord. However, for the moment I am fine with your change.
Tzvetan Popov - 2014-10-30 13:28:20 +0100
(In reply to Robert Oostenveld from comment #1) Ok, thanks.
Tzvetan Popov - 2014-10-30 13:33:12 +0100
(In reply to Robert Oostenveld from comment #1) How would I commit the change since it is not under version control? bash-4.1$ svn commit ft_source2full.m -m 'bugfix- ft_source2full added explicit care for the field 'inside' see http://bugzilla.fcdonders.nl/show_bug.cgi?id=2749' svn: Commit failed (details follow): svn: '/home/electromag/tzvpop/fieldtrip/ft_source2full.m' is not under version control
Robert Oostenveld - 2014-10-30 14:05:24 +0100
(In reply to Tzvetan Popov from comment #3) It seems that you moved the file around. It should be located in fieldtrip/utilities.
Tzvetan Popov - 2014-10-30 14:10:54 +0100
(In reply to Robert Oostenveld from comment #4) Aaa, ...sure now it works. Stupido-Im still learning :-) bash-4.1$ svn commit ft_source2full.m -m 'bugfix- ft_source2full added explicit care for the field 'inside' see http://bugzilla.fcdonders.nl/show_bug.cgi?id=2749' Sending ft_source2full.m Transmitting file data . Committed revision 9933.
Tzvetan Popov - 2014-10-30 14:11:58 +0100
bash-4.1$ svn commit ft_source2full.m -m 'bugfix- ft_source2full added explicit care for the field 'inside' see http://bugzilla.fcdonders.nl/show_bug.cgi?id=2749' Sending ft_source2full.m Transmitting file data . Committed revision 9933.