Back to the main page.
Bug 2852 - deprecate ft_analysisprotocol
| Status | REOPENED |
| Reported | 2015-02-23 14:30:00 +0100 |
| Modified | 2015-02-23 21:43:57 +0100 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P5 normal |
| Assigned to: | Jim Herring |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Jim Herring - 2015-02-23 14:30:29 +0100
Currently ft_analysispipeline has fully taken over the functionality of ft_analysisprotocol but the latter function has not yet been deprecated. As discussed in the Ft-meeting of 23-2-2015 ft_analysisprotocol can be removed after having checked whether it is not still used somewhere else in the code. bash-4.1$ grep -r "ft_analysisprotocol" ./ ./private/menu_pipeline.m:% ft_analysisprotocol([], varargin{1}); ./test/test_ft_datatype_source.m:% the style of this is also used in test_ft_analysisprotocol and test_ft_datatype ./test/test_ft_datatype.m:%% this style is also used in test_ft_analysisprotocol and test_ft_datatype_source ./test/test_ft_analysisprotocol.m:function test_ft_analysisprotocol ./test/test_ft_analysisprotocol.m:% TEST test_ft_analysisprotocol ./test/test_ft_analysisprotocol.m:% TEST ft_analysisprotocol ./test/test_ft_analysisprotocol.m: ft_analysisprotocol(cfg, var); ./test/test_bug1811.m:% TEST ft_analysisprotocol ./test/test_bug1811.m:[script, details]=ft_analysisprotocol(cfg,meeg); ./test/test_bug1811.m:[script, details]=ft_analysisprotocol(cfg,data); ./ft_analysispipeline.m:% output = ft_analysisprotocol(cfg, data) ./ft_analysisprotocol.m:function [script, details] = ft_analysisprotocol(cfg, data) ./ft_analysisprotocol.m:% ft_analysisprotocol(cfg, data) ./ft_analysisprotocol.m:% $Id: ft_analysisprotocol.m 10196 2015-02-11 09:15:07Z roboos $ ./ft_analysisprotocol.m:revision = '$Id: ft_analysisprotocol.m 10196 2015-02-11 09:15:07Z roboos $'; ./ft_analysisprotocol.m: ft_analysisprotocol(cfg, datacfg.previous); ./ft_analysisprotocol.m: ft_analysisprotocol(cfg, datacfg.previous{i}); ./ft_analysisprotocol.m: ft_analysisprotocol(cfg, datacfg.(fn{i}).cfg); bash-4.1$ I will check the code that still uses ft_analysisprotocol and will remove it after having updated the code to use ft_analysispipeline.
Robert Oostenveld - 2015-02-23 14:33:27 +0100
could you also add it to this list? http://fieldtrip.fcdonders.nl/development/deprecated
Jim Herring - 2015-02-23 14:45:48 +0100
Update: bash-4.1$ grep -r "ft_analysisprotocol" ./ ./private/menu_pipeline.m:% ft_analysisprotocol([], varargin{1}); - Removed the comment ./test/test_ft_datatype_source.m:% the style of this is also used in test_ft_analysisprotocol and test_ft_datatype - nothing done here ./test/test_ft_datatype.m:%% this style is also used in test_ft_analysisprotocol and test_ft_datatype_source - nothing done here ./test/test_ft_analysisprotocol.m:function test_ft_analysisprotocol - removed test_ft_analysisprotocol ./test/test_ft_analysisprotocol.m:% TEST test_ft_analysisprotocol - removed test_ft_analysisprotocol ./test/test_ft_analysisprotocol.m:% TEST ft_analysisprotocol - removed test_ft_analysisprotocol ./test/test_ft_analysisprotocol.m: ft_analysisprotocol(cfg, var); - removed test_ft_analysisprotocol ./test/test_bug1811.m:% TEST ft_analysisprotocol - updated to use ft_analysispipeline ./test/test_bug1811.m:[script, details]=ft_analysisprotocol(cfg,meeg); - updated to use ft_analysispipeline ./test/test_bug1811.m:[script, details]=ft_analysisprotocol(cfg,data); - updated to use ft_analysispipeline ./ft_analysispipeline.m:% output = ft_analysisprotocol(cfg, data) - updated documentation ./ft_analysisprotocol.m:function [script, details] = ft_analysisprotocol(cfg, data) - removed ft_analysisprotocol ./ft_analysisprotocol.m:% ft_analysisprotocol(cfg, data) - removed ft_analysisprotocol ./ft_analysisprotocol.m:% $Id: ft_analysisprotocol.m 10196 2015-02-11 09:15:07Z roboos $ - removed ft_analysisprotocol ./ft_analysisprotocol.m:revision = '$Id: ft_analysisprotocol.m 10196 2015-02-11 09:15:07Z roboos $'; - removed ft_analysisprotocol ./ft_analysisprotocol.m: ft_analysisprotocol(cfg, datacfg.previous); - removed ft_analysisprotocol ./ft_analysisprotocol.m: ft_analysisprotocol(cfg, datacfg.previous{i}); - removed ft_analysisprotocol ./ft_analysisprotocol.m: ft_analysisprotocol(cfg, datacfg.(fn{i}).cfg); - removed ft_analysisprotocol bash-4.1$ Sending ft_analysispipeline.m Deleting ft_analysisprotocol.m Sending test/test_bug1811.m Deleting test/test_ft_analysisprotocol.m Transmitting file data .. Committed revision 10246.
Jim Herring - 2015-02-23 14:48:13 +0100
@Robert: Done!