Back to the main page.
Bug 2860 - ft_rejectvisual
| Status | CLOSED FIXED |
| Reported | 2015-02-27 13:47:00 +0100 |
| Modified | 2017-01-17 11:29:46 +0100 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Windows |
| Importance: | P5 normal |
| Assigned to: | Robert Oostenveld |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Ivan - 2015-02-27 13:47:53 +0100
Function "ft_rejectvisual" with methods "summary", not allows to reject a trials while the observation mode is "min".
Robert Oostenveld - 2015-02-27 14:51:11 +0100
You are right, I can confirm the problem with load dataFIC cfg = []; cfg.method = 'summary', cfg.metric = 'min'; ft_rejectvisual(cfg, dataFIC) Selecting to any other metric in the interface, I am able to reject trials (in the lower left figure), but somehow it fails with "min". This may be related to this (line 212 in private/rejectvisual_summary.m) % we need a workaround when finding the max of the minima if strcmp(info.metric, 'min') level = level * -1; end or some other inversion/flipping of the values. The reason I suspect this, is that all other metric values are positive, whereas min is expected to be negative (for most data).
Robert Oostenveld - 2016-06-22 16:33:14 +0200
hmm, this bug has been open for quite some time... Sorry about that. I just resolved it. mac011> git commit -a [master bde2e63] FIX - allow selection in ft_rejectvisual if metric=min, see http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=2860 1 file changed, 16 insertions(+), 18 deletions(-) mac011> git push upstream master X11 forwarding request failed on channel 0 You're about to push master, is that what you intended? [y|n] y Counting objects: 6, done. Delta compression using up to 4 threads. Compressing objects: 100% (6/6), done. Writing objects: 100% (6/6), 902 bytes | 0 bytes/s, done. Total 6 (delta 4), reused 0 (delta 0) To git@github.com:fieldtrip/fieldtrip.git 9a58325..65159df master -> master