Back to the main page.
Bug 2898 - ft_sourcestatistics: low-level machinery does not seem to take into account inside
Status | CLOSED FIXED |
Reported | 2015-05-20 14:15:00 +0200 |
Modified | 2017-01-17 11:30:36 +0100 |
Product: | FieldTrip |
Component: | core |
Version: | unspecified |
Hardware: | PC |
Operating System: | Windows |
Importance: | P5 normal |
Assigned to: | Jan-Mathijs Schoffelen |
URL: | |
Tags: | |
Depends on: | |
Blocks: | |
See also: |
Jan-Mathijs Schoffelen - 2015-05-20 14:15:50 +0200
Nietzsche discovered this because she is using a funky statfun that crashes with nans in the data (being defined on the outside voxels). As far as I remember, in the past ft_sourcestatistics pruned the 'dat'-matrix that went into ft_statistics_montecarlo to contain only the inside voxels. It could be that this feature has disappeared.
Jan-Mathijs Schoffelen - 2015-05-20 14:19:26 +0200
added test data and funky statfun to /home/common/matlab/fieldtrip/data/bug2898
Jan-Mathijs Schoffelen - 2016-01-25 15:38:26 +0100
I am running into it now as well. Will investigate and try to fix.
Jan-Mathijs Schoffelen - 2016-12-23 13:01:08 +0100
Update: I verified this quickly by hand, and this indeed the case. I suspect that this may have consequences for spatial clustering
Jan-Mathijs Schoffelen - 2016-12-23 14:16:20 +0100
I have provided a fix for this in a branch of my FT fork: bug2898
Jan-Mathijs Schoffelen - 2017-01-05 10:51:49 +0100
PR286 on github.com takes care of this