Back to the main page.
Bug 2922 - iscolumn is missing in matlab 2010a
Status | CLOSED FIXED |
Reported | 2015-07-09 12:19:00 +0200 |
Modified | 2019-08-10 12:30:44 +0200 |
Product: | FieldTrip |
Component: | core |
Version: | unspecified |
Hardware: | PC |
Operating System: | Mac OS |
Importance: | P5 normal |
Assigned to: | |
URL: | |
Tags: | |
Depends on: | |
Blocks: | |
See also: | http://bugzilla.fieldtriptoolbox.org/show_bug.cgi?id=2567 |
Robert Oostenveld - 2015-07-09 12:19:10 +0200
as detected in Barcelona... probably isrow is also missing. I don't know from which version on the function exists.
Robert Oostenveld - 2015-07-09 12:22:00 +0200
related to octave the plan was anyway to make a set of matlab version-dependent directories that should be added to the path. E.g. if is column were added in 2010b, I suggest to put it in fieldtrip/compat/pre2010b and ft_defaults would have to be updated. We could have fieldtrip/compat/octave and fieldtrip/compat/pre2010a fieldtrip/compat/pre2010b fieldtrip/compat/pre2011a fieldtrip/compat/pre2011b fieldtrip/compat/pre2012a fieldtrip/compat/pre2012b fieldtrip/compat/pre2013a fieldtrip/compat/pre2013b etc.
Jörn M. Horschig - 2015-07-09 12:28:14 +0200
isrow it is definitely present in 2012b as I made a personal replacement function a while ago and just received annoying warnings about 'shadowing' the built-in function. I would use something like if ~exist('isrow', 'builtin') addpath(...) that would remove the necessity to do a check by matlabversion
Jim Herring - 2015-07-09 12:34:30 +0200
According to http://www.dynare.org/DynareWiki/MatlabVersionsCompatibility isrow/iscolumn/ismatrix was added in 2010b. As 2010a is more than 5 years old (5 March 2010), we do not officially support it anymore, however, I do like the idea of having compat folders for the different versions we are still supporting :p
Jörn M. Horschig - 2015-07-09 13:56:19 +0200
(In reply to Jörn M. Horschig from comment #2) just thought about my suggestion, and I think it's a stupid idea. organizing it by matlab version will be much cleaner and easier to maintain
Robert Oostenveld - 2015-07-09 14:23:42 +0200
I also updated the code related to bug 2922.