Back to the main page.
Bug 2924 - use neuralynx mex files
| Status | ASSIGNED |
| Reported | 2015-07-10 14:37:00 +0200 |
| Modified | 2015-07-16 16:56:08 +0200 |
| Product: | FieldTrip |
| Component: | fileio |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P5 normal |
| Assigned to: | Robert Oostenveld |
| URL: | https://github.com/fieldtrip/fieldtrip/pull/66 |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Robert Oostenveld - 2015-07-10 14:37:29 +0200
As suggested in https://github.com/fieldtrip/fieldtrip/pull/65
Robert Oostenveld - 2015-07-10 14:40:06 +0200
Created attachment 716 ft_hastoolbox detect neuralynx mex files (now in FT style)
Robert Oostenveld - 2015-07-10 14:41:18 +0200
Created attachment 717 read_neuralynx_ncs changed error handling (the error should not be postponed, in general avoid try-catch as much as possible), use ft_hastoolbox
Robert Oostenveld - 2015-07-13 10:10:26 +0200
Mike made another pull request after testing. I did some additional tests and it turned out that the mex files do record indexing that start with 0 rather than 1. The following works on my computer (maci64) with the mex files (after stripping the "_v3" from the filename). I compared the mex versus original implementation, both for continuous and segmented reading. mac011> svn commit fileio/ft_read_data.m fileio/private/ft_hastoolbox.m fileio/private/read_neuralynx_ncs.m Sending fileio/ft_read_data.m Sending fileio/private/ft_hastoolbox.m Sending fileio/private/read_neuralynx_ncs.m Transmitting file data ... Committed revision 10529.
Robert Oostenveld - 2015-07-13 17:12:45 +0200
I have reverted the change, i.e. it now does not use mex files. Before it gets enabled we have to ensure that the 0/1 offset indexing is correct on all platforms. mac011> svn commit fileio/private/read_neuralynx_ncs.m Sending fileio/private/read_neuralynx_ncs.m Transmitting file data . Committed revision 10533.