Back to the main page.
Bug 2929 - ft_artifact_zvalue expects function hline - not part of distribution?
| Status | CLOSED FIXED |
| Reported | 2015-07-15 11:26:00 +0200 |
| Modified | 2016-06-14 16:14:50 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | Other |
| Operating System: | Linux |
| Importance: | P5 normal |
| Assigned to: | Robert Oostenveld |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Stephen Whitmarsh - 2015-07-15 11:26:25 +0200
Hi There! My colleague Fanny is trying out ft_artifact_zvalue but it breaks expecting a function hline which is not in the FieldTrip distribution, and neither is it in our Matlab2015a. We have the most recent revision 10535. There is a hline function on the Matlab fileexchange, but we're not sure whether it belongs in the FT distribution. What do you think? ------------- Undefined function 'hline' for input arguments of type 'double'. Error in ft_artifact_zvalue>redraw_cb (line 962) hline(opt.threshold, 'color', 'r', 'linestyle', ':', 'displayname', 'threshline'); Error in ft_artifact_zvalue (line 490) redraw_cb(h); --------------
Robert Oostenveld - 2015-07-16 11:49:07 +0200
ja, ja... we hebben het wel gezien! Once upon a time we had this one https://code.google.com/p/fieldtrip/source/browse/trunk/private/hline.m?r=7451 but in my latest version it also does not exist in fieldtrip/private any more.
Robert Oostenveld - 2015-07-16 11:54:19 +0200
using svn log -v > log.txt I was able to pin it down to this revision r8410 | eelspa | 2013-08-21 16:16:44 +0200 (Wed, 21 Aug 2013) | 3 lines Changed paths: ... enhancement(2208): moved all the statistics drop-in replacements (including nan*) to external/stats/ (commit 1 of 2) So it links to bug #2208, which is about external/stats. And then in r10467 | roboos | 2015-06-22 18:52:46 +0200 (Mon, 22 Jun 2015) | 2 lines Changed paths: D /trunk/external/stats/hline.m D /trunk/external/stats/vline.m restructuring - these two functions don't belong here I apparently found out and deleted them over there...
Robert Oostenveld - 2015-07-16 12:00:47 +0200
mac011> svn up -r 10466 hline.m Updating 'hline.m': A hline.m Updated to revision 10466. mac011> svn up -r 10466 vline.m Updating 'vline.m': A vline.m Updated to revision 10466. mac011> svn move hline.m vline.m ../../private/ A /Users/roboos/matlab/fieldtrip/private/hline.m D hline.m A /Users/roboos/matlab/fieldtrip/private/vline.m D vline.m ... en toen moest ik wat conflicten oplossen mac011> svn commit external/stats private/ Adding private/hline.m Adding private/vline.m Committed revision 10548.
Stephen Whitmarsh - 2015-07-16 13:08:26 +0200
Thanks guys!