Back to the main page.
Bug 2951 - implement lagged coherence in ft_connectivityanalysis
| Status | CLOSED FIXED |
| Reported | 2015-08-26 12:50:00 +0200 |
| Modified | 2021-10-29 12:38:39 +0200 |
| Product: | FieldTrip |
| Component: | core |
| Version: | unspecified |
| Hardware: | PC |
| Operating System: | Mac OS |
| Importance: | P5 enhancement |
| Assigned to: | |
| URL: | |
| Tags: | |
| Depends on: | |
| Blocks: | |
| See also: |
Robert Oostenveld - 2015-08-26 12:50:50 +0200
this was discussed so far over email between Anne, Eric and me. This topic on bugzilla serves to keep the discussion and progress manageable.
Robert Oostenveld - 2015-08-26 12:53:39 +0200
mac011> svn commit ft_connectivity_laggedcoherence.m Adding ft_connectivity_laggedcoherence.m Transmitting file data . Committed revision 10629.
Robert Oostenveld - 2015-08-26 12:56:18 +0200
the following test scripts (in fieldtrip/test) are testing other connectivity measures and could serve as template for implementing test_ft_connectivity_laggedcoherence.m
Robert Oostenveld - 2015-08-26 12:57:21 +0200
(In reply to Robert Oostenveld from comment #2) sorry, here they are mac011> grep -l ft_connectivity_ *.m test_bug1425.m test_bug2004.m test_bug2469.m test_bug2761.m test_ft_connectivity_powcorr_ortho.m test_ft_connectivityanalysis.m
Robert Oostenveld - 2015-08-26 13:09:36 +0200
I made a first test script, note that it will still fail because the implementation is incomplete. But it demonstrates how the end-user would call it from an analysis script. mac011> svn commit test_ft_connectivity_laggedcoherence.m Adding test_ft_connectivity_laggedcoherence.m Transmitting file data . Committed revision 10631.
Robert Oostenveld - 2015-08-26 13:11:17 +0200
the low level function specest/ft_connectivity_laggedcoherence should not have cfg inputs, but key value pairs. Please compare it to the other functions in the specest directory.
Jan-Mathijs Schoffelen - 2016-02-22 09:39:20 +0100
Will this be pushed forward anytime soon? I would assume that Eric's team will follow up on this. If that's not the case, I suggest to abandon this bug for the time being, and close it. The current version of the code is not functional at all. If it's not to change in the near future, I suggest to remove it from the repository.
Jan-Mathijs Schoffelen - 2016-02-22 09:59:34 +0100
One addition: if it's decided to further work on this, I suggest to do this in a separate branch on git. We have recently entirely moved to github for version control, and git provides convenient functionality to develop new functionality in separate branches, avoiding half-finished projects in the 'release' version of the code, which in turn ensures a much more stable software.
Eric Maris - 2016-02-22 10:25:57 +0100
(In reply to Jan-Mathijs Schoffelen from comment #7) Can the relevant code (pertaining to lagged coherence) by organised in Github in such a way that I can modify it in such a way that it does not disturb the functionality of the release version as a whole. If so, I would like to know whether and how this is achieved. I could also drop down by your office and you could just show me where it is (and authorise me to make changes). best, Eric
Jan-Mathijs Schoffelen - 2016-02-22 10:35:32 +0100
(In reply to Eric Maris from comment #8) Hi Eric, It most certainly can! It's no problem to show you how to get started. There's already quite some useful information in the link below. http://www.fieldtriptoolbox.org/development/git Otherwise, just drop by.
Robert Oostenveld - 2019-11-18 11:41:50 +0100
This has been addressed with https://github.com/fieldtrip/fieldtrip/issues/1217 https://github.com/fieldtrip/fieldtrip/pull/1233 https://github.com/fieldtrip/fieldtrip/pull/1259