Back to the main page.

Bug 2956 - implement spectral interpolation as alternative to zeroing in DFT filter

Status CLOSED FIXED
Reported 2015-08-31 14:39:00 +0200
Modified 2019-08-10 12:40:29 +0200
Product: FieldTrip
Component: preproc
Version: unspecified
Hardware: PC
Operating System: Mac OS
Importance: P5 normal
Assigned to: Sarang Dalal
URL:
Tags:
Depends on:
Blocks:
See also:

Robert Oostenveld - 2015-08-31 14:39:50 +0200

as discussed in FT meeting. Options will look like this cfg.dftfilter = 'yes' cfg.dftfreq = [50 100 150]; % in Hz cfg.dftbandwidth = [1 2 3]; % in Hz cfg.dftreplace = 'zero' or 'neighbour'; cfg.dftneighbourwidth = [2 2 2]; % in Hz and ft_preproc_dftfilter will handle it all. step 1) Robert will make test script and update existing code to deal with new options. step 2) Sarang will plug in new functionality.


Sabine Leske - 2016-10-21 13:58:28 +0200

(In reply to Robert Oostenveld from comment #0) Hi Robert, I would like to integrate the spectrum interpolation code into FieldTrip. Would you like to update the code with the new suggested cfg-options (cfg.dftbandwidth etc..) and test it first? Or I could also give it a try and add the new cfg-options myself, if you prefer?


Robert Oostenveld - 2016-11-04 10:08:18 +0100

(In reply to Sabine Leske from comment #1) Hi Sabine, Please follow http://www.fieldtriptoolbox.org/contribute?&#contribute_code, make a fork on github and send a PR. it would be good if you would also add fieldtrip/test/test_bug2956.m which would have some code to demonstrate and test the new functionality. thanks Robert


Sabine Leske - 2017-02-08 11:31:52 +0100

(In reply to Robert Oostenveld from comment #2) The new functionality (spectrum interpolation) was integrated into ft_preproc_dftfilter.m with the commits of: Bug2956 and dftfilter bugfix #272 Thank you for merging.


Robert Oostenveld - 2019-08-10 12:34:18 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.


Robert Oostenveld - 2019-08-10 12:40:29 +0200

This closes a whole series of bugs that have been resolved (either FIXED/WONTFIX/INVALID) for quite some time. If you disagree, please file a new issue on https://github.com/fieldtrip/fieldtrip/issues.